Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

Fix character import drag-and-drop handling#51

Draft
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/38-character-import-dnd
Draft

Fix character import drag-and-drop handling#51
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/38-character-import-dnd

Conversation

@Promansis
Copy link
Copy Markdown
Collaborator

Linked issue

Closes #38

Why this change

  • The Import Character modal could lose drag hover state when dragged items crossed nested drop-zone elements, and folder/unsupported drops could fail without a clear rejection.

What changed

  • React UI owner: src/features/characters/components/ImportCharacterModal.tsx.
  • Track drag depth for stable enter/leave handling.
  • Stop propagation on drop-zone drag events and set a copy drop effect for supported file drops.
  • Inspect DataTransferItems so folder-like or unsupported drops show a clear error instead of silently doing nothing.
  • Updated the local bug ownership note under updates/people/promansis.md.

Validation

  • pnpm typecheck
  • pnpm build
  • cargo check --manifest-path src-tauri/Cargo.toml
  • pnpm check:docs when docs, skills, or repo guidance changed
  • Ran pnpm tauri dev and tested the app path manually
  • Verified the affected feature in the right mode(s): chat, roleplay, game, settings/providers, imports/exports, or assets

Manual verification notes

  • Not manually verified in the desktop app yet.
  • Suggested smoke: run pnpm tauri dev, open Settings -> Import Character, drop .json, .png, .charx, and .marinara files, then drop a folder. Supported files should import normally; folder/unsupported drops should show a clear rejection and the drag highlight should not flicker or get stuck.

Docs impact

  • No docs changes needed
  • Updated docs/developer/* or repo guidance as needed

UI evidence

  • Not captured.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a2634382-e3b2-45a2-ac5f-a90f29d4b955

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Character import drag-and-drop handling

2 participants