This repository was archived by the owner on May 24, 2026. It is now read-only.
[codex] Avoid lazy loading local character avatars#53
Draft
Promansis wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #37
Why this change
Importing multiple PNG character cards can immediately refresh character avatar thumbnails with local inline image data. Those thumbnails were marked for lazy loading, which can produce browser console warnings around load timing even though the image source is already local to the app.
What changed
data:andblob:avatar sources eager while preserving lazy loading for normal URLs.Owner layer: React UI in
src/features/characters.Validation
pnpm typecheckpnpm buildcargo check --manifest-path src-tauri/Cargo.tomlpnpm check:docswhen docs, skills, or repo guidance changedpnpm tauri devand tested the app path manuallyAlso ran the combined
pnpm check, which completed frontend typecheck, Rust check, and docs guidance check.Manual verification notes
Manual desktop smoke still needed: run
pnpm tauri dev, open Character Library, import multiple PNG character cards, keep the browser/devtools console open, and confirm import succeeds without the lazy-load warning appearing as the new cards render.Docs impact
docs/developer/*or repo guidance as neededUI evidence
No screenshot attached; this fixes browser console behavior for local character avatar rendering.