Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

[codex] Avoid lazy loading local character avatars#53

Draft
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/37-multi-png-lazy-load-warning
Draft

[codex] Avoid lazy loading local character avatars#53
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/37-multi-png-lazy-load-warning

Conversation

@Promansis
Copy link
Copy Markdown
Collaborator

Linked issue

Closes #37

Why this change

Importing multiple PNG character cards can immediately refresh character avatar thumbnails with local inline image data. Those thumbnails were marked for lazy loading, which can produce browser console warnings around load timing even though the image source is already local to the app.

What changed

  • Added a characters-owned avatar loading helper that keeps data: and blob: avatar sources eager while preserving lazy loading for normal URLs.
  • Applied the helper to Character Library card thumbnails and character group member thumbnails.
  • Updated the local Promansis work tracker for issue Multi-PNG lazy-load warning #37.

Owner layer: React UI in src/features/characters.

Validation

  • pnpm typecheck
  • pnpm build
  • cargo check --manifest-path src-tauri/Cargo.toml
  • pnpm check:docs when docs, skills, or repo guidance changed
  • Ran pnpm tauri dev and tested the app path manually
  • Verified the affected feature in the right mode(s): chat, roleplay, game, settings/providers, imports/exports, or assets

Also ran the combined pnpm check, which completed frontend typecheck, Rust check, and docs guidance check.

Manual verification notes

Manual desktop smoke still needed: run pnpm tauri dev, open Character Library, import multiple PNG character cards, keep the browser/devtools console open, and confirm import succeeds without the lazy-load warning appearing as the new cards render.

Docs impact

  • No docs changes needed
  • Updated docs/developer/* or repo guidance as needed

UI evidence

No screenshot attached; this fixes browser console behavior for local character avatar rendering.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 287a48bb-d528-4b98-9c41-e99adf48d389

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-PNG lazy-load warning

2 participants