Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

[codex] fix character cache churn#54

Draft
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/39-character-cache-churn
Draft

[codex] fix character cache churn#54
Promansis wants to merge 1 commit into
Pasta-Devs:mainfrom
Promansis:bug/39-character-cache-churn

Conversation

@Promansis
Copy link
Copy Markdown
Collaborator

Closes #39

Why this change

Character import and delete paths were refreshing the full character list even when the mutation response already contained enough data to patch the React Query cache. That caused avoidable refetch churn in the character UI.

What changed

  • Added small character-list cache helpers in the character feature hook owner.
  • Updated create, duplicate, delete, and import flows to patch the list cache directly when the response contains a usable character record.
  • Kept a single invalidation fallback when a successful import does not return enough data to patch the cache safely.
  • Recorded the issue ownership update in the local updates file.

Validation

  • pnpm typecheck
  • pnpm check
  • Ran pnpm tauri dev and tested the app path manually
  • Verified the affected feature in the right mode(s): imports/exports

Manual verification notes

Validated the character cache update path via typecheck and repo checks; the app-side manual smoke still needs a live desktop run for import/delete refetch observation.

Docs impact

  • No docs changes needed

UI evidence

  • None

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ddb9a7bd-b057-4b2f-95af-51549e0d9eb4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Character import/delete cache churn

2 participants