Skip to content

Full Prof Mari upgrade#1235

Closed
munimunigamer wants to merge 10 commits into
refactorfrom
feat/prof-mari-optimizations
Closed

Full Prof Mari upgrade#1235
munimunigamer wants to merge 10 commits into
refactorfrom
feat/prof-mari-optimizations

Conversation

@munimunigamer
Copy link
Copy Markdown
Collaborator

@munimunigamer munimunigamer commented May 26, 2026

Overview

Full Prof Mari upgrade covering the agent runtime, creative-library workspace, approval checkpoints, trace visibility, and chat UI polish.

What's included

Agent workspace

  • Adds a Bashkit-backed virtual /workspace for Prof Mari.
  • Maps friendly workspace paths to internal creative-library records.
  • Supports read, bash, edit, and write tools.
  • Adds directory-aware reads with folder listings or index.md content.
  • Adds root and folder-level FORMAT.md guides for characters, personas, lorebooks, prompts, groups, entries, sections, variables, and related records.

Approval and persistence flow

  • Tracks tool changes at the VFS/file-diff layer instead of parsing command names.
  • Pauses after mutating tools change files, before the tool result returns to the agent loop.
  • Emits live approval requests to the UI with focused file diffs.
  • Persists approved edits through creative-library storage APIs.
  • Rolls back rejected edits to the pre-tool workspace snapshot.
  • Rejects workspace-only or non-mappable changes with a clear error instead of silently accepting them.
  • Serializes mutating tool review to avoid parallel unapproved-change races.

Prof Mari UI and API

  • Adds live approval and change-review panels.
  • Adds frontend approval request/outcome types and API wrappers.
  • Shows create diffs as new content and metadata changes as readable field rows.
  • Adds trace visibility for observable model/tool activity.
  • Refreshes the Prof Mari chat surface with a fuller, cleaner layout and Mari-focused presentation.
  • Updates message styling, avatar/persona handling, and sprite layering/positioning.

Runtime and mobile cleanup

  • Removes the unused AutoAgents codeact feature so mobile builds no longer pull rquickjs-sys/QuickJS bindings.
  • Treats max output 0/unset as no explicit provider output cap where the provider API allows it.

Verification

cargo check --manifest-path src-tauri/Cargo.toml
pnpm typecheck
pnpm check:architecture

Manual testing still needed

  • In-app approve/reject checkpoint flow.
  • Top-level creative-library create flows on Windows.
  • Visual review of text, metadata, create, modify, and delete diffs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b6d60ea7-54c3-481d-94f1-ce0333c83282

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/prof-mari-optimizations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the feature New feature or enhancement label May 26, 2026
@munimunigamer munimunigamer changed the title Prof Mari workspace approvals Full Prof Mari upgrade May 26, 2026
@SpicyMarinara
Copy link
Copy Markdown
Collaborator

Closing this draft without pulling it because the current Prof Mari/refactor runtime has moved substantially and this branch is now a broad conflicting rewrite across Rust Mari storage, LLM transport, and the chat surface. Pieces of the idea may still be valuable, but they need to be split/rebased into small refactor-native PRs after the current Mari runtime settles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants