Add support for Cadiro's Gambit - #2422
Open
kylande01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2415 .
Description of the problem being solved:
Cadiro's Gambit was lacking support, only granting the implicit attack speed modifier.
This update adds an item-gated configuration dropdown with "Not selected" as its default. Users can select between the six mutually exclusive arrow types for each arrow type applying its changes across PoB for:
Each selection applies only that arrow's effects, and all effects are scoped to Arrow skills. Reversing Arrow also displays its 100% Return Chance in the Calcs panel, but does not include added DPS calculations to avoid false damage reporting. Dropdown tooltips describe the effect of each arrow as per the affix descriptions from poe2db.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/wHXUWmsIXjgP
This is a basic build using Shockchain Arrow on a Deadeye just to make sure all arrow interactions are accounted for. All automated integration tests also passed
Before screenshot:
After screenshot:
With six different arrow types I won't flood this page with screenshots. Please feel free to verify further if needed.
I'm a long time user of PoB and a first time contributor. If I've made any sort of error in this request at all, please let me know and I'll fix it immediately. Thank you!