Skip to content

Add Minion Rage configuration support - #2425

Open
kylande01 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
kylande01:codex/minion-rage
Open

Add Minion Rage configuration support#2425
kylande01 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
kylande01:codex/minion-rage

Conversation

@kylande01

@kylande01 kylande01 commented Aug 23, 2026

Copy link
Copy Markdown

Addresses #2348 .

Description of the problem being solved:

As of patch 0.5, minions are able to accumulate rage stacks through supports. However, minions that were able to gain Rage through supports or Skeletal Reavers natural Rage modifier did not have their Rage configured. Their Maximum Rage was also reported as zero, preventing existing generic Rage calculations from applying its more Attack Damage multiplier.

This update adds a Minion Rage configuration option that is displayed when a selected minion can gain Rage:

  • Minions supported by a Rage support gem receive the CanGainRage condition.
  • Skeletal Reavers receive the condition intrinsically.
  • Minions receive the base Maximum Rage value and use the existing generic Rage calculation.
  • Skeletal Reavers gain 3% increased Attack Speed per effective Rage.
  • Skeletal Reaver quality correctly increases Rage effect.
  • Rage III grants its conditional Attack Speed while the minion is below its actual Maximum Rage.
  • Generic Maximum Rage modifiers copied to minions are respected, including the Rabid Talisman implicit copied by Manifest Weapon.

Any configured Rage value is also capped by the minion's calculated MaximumRage

Steps taken to verify a working solution:

  • Confirmed the Minion Rage option is hidden for unsupported non-Reaver minions.
  • Confirmed it appears for Rage-supported minions and unsupported Skeletal Reavers.
  • Confirmed Rage applies its more Attack Damage multiplier.
  • Confirmed Skeletal Reaver Attack Speed and quality scaling.
  • Confirmed Rage III Attack Speed is removed at Maximum Rage.
  • Confirmed Manifest Weapon receives the Rabid Talisman's +10 to Maximum Rage and treats 40 Rage as its maximum.
  • Added nine automated system regression tests.
  • Ran the complete Busted suite: 584 successes, 0 failures, and 0 errors.

Link to a build that showcases this PR:

https://pobb.in/vA6eejST0hhw
Bit of a nonsense Lich build, not necessarily any specific variant. I just pathed to a bunch of minion nodes and added various minion skills with appropriate supports to test the new Rage configurations. Changes to Manifest Weapon passed in both regression testing and full suite testing, so this should be working correctly.

Before screenshot:

image image

After screenshot:

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant