Add Minion Rage configuration support - #2425
Open
kylande01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2348 .
Description of the problem being solved:
As of patch 0.5, minions are able to accumulate rage stacks through supports. However, minions that were able to gain Rage through supports or Skeletal Reavers natural Rage modifier did not have their Rage configured. Their Maximum Rage was also reported as zero, preventing existing generic Rage calculations from applying its more Attack Damage multiplier.
This update adds a Minion Rage configuration option that is displayed when a selected minion can gain Rage:
Any configured Rage value is also capped by the minion's calculated MaximumRage
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/vA6eejST0hhw
Bit of a nonsense Lich build, not necessarily any specific variant. I just pathed to a bunch of minion nodes and added various minion skills with appropriate supports to test the new Rage configurations. Changes to Manifest Weapon passed in both regression testing and full suite testing, so this should be working correctly.
Before screenshot:
After screenshot: