Fix invalid mod parsing for mods that grant skills - #10174
Merged
LocalIdentity merged 3 commits intoAug 23, 2026
Merged
Conversation
LocalIdentity
approved these changes
Aug 23, 2026
LocalIdentity
merged commit Aug 23, 2026
d815ced
into
PathOfBuildingCommunity:dev
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10170
Description of the problem being solved:
Pasting a Misted ring with '50% increased Suffix Modifier magnitudes' and the suffix 'Grants Level 20 Aspect of Lunaris Skill' crashed PoB. The Aspect line is unparseable as it isn't present in the skill data yet, so 'grantedExtraSkill' returns a single nil value instead of the mod list values. The mod magnitude scaling loop then matched this line and overwrote its modList value with nil even though the re-parse also failed. Later 'processModLine' iterated over the now nil modList, throwing bad args to the ipairs call.
Updated the magnitude scaling loop to only overwrite
modListandextrawhen the re-parse succeeds, leaving failed lines in their original display-only state.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: