Skip to content

Fix custom item mod sections not hiding properly - #10175

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Trifall:fix/10169-crafted-mod-stuck-ui
Aug 23, 2026
Merged

Fix custom item mod sections not hiding properly#10175
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Trifall:fix/10169-crafted-mod-stuck-ui

Conversation

@Trifall

@Trifall Trifall commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #10169

Description of the problem being solved:

In the Items tab, adding a crafted or custom modifier to an item and then saving it left the crafted mod line and its "Remove" button stuck on screen behind the helper text.

Added a visibility handler on 'displayItemSectionCustom' that returns whether a display item is present, matching the way the other UI elements' visibility is controlled.

Steps taken to verify a working solution:

  • Added a regression test that saves a crafted item and asserts the Remove button and crafted-mod label are no longer shown
  • Verified the new test fails on the unfixed code and passes after the fix
  • Confirmed the existing tests still show custom-modifier controls on imported items and affix controls on items crafted in PoB
  • All tests passed

Link to a build that showcases this PR:

Edit the Helical Ring -> Save -> 'Remove' buttons now incorrectly showing overlapped with the helper text.

eNq1XEtz2zgSPke_AqWqOc3E1tuyy54pWbZj19qJVnKS3VMKJiEJG4jQkqBtTcr_fbsBkiIlSgRNbQ4JRfbX6G40-kVWzv96XQjyzPyAS--i3jxq1AnzHOlyb3ZR__p487Ff_-vP2vmIqvmX6WXIBT75s_bhXF8TRf0ZU99ifPsH4J85e3mQLruo3z2Mvowf64QGDvPcoaBB8Jku4MFn6bE6cebUp45i_j17ZmIQKmlgyg_hqcCbIFKdPFHP5SpGLSj3JtL5ydQnX4ZLTbGknpoz6T1wT_qfpBvTJvfpfzL3nbUoEwckr4NGH85Hgq6YP1FUkWcqQnjYOGr0-ifdOgng5kV9AIaiM3ZFF_B3_bgU6DL0A1WAbB61YtRkyZi7e4mYbOSz6-mUOYo_s6HP1XBOPYcV4yxoW0eNkzT5QygUXwrO_J2QROfbYkmOGv1WQv8oFRVXo0mx4IZSKkvG37maXwow5V7mW5C7mccVK4cZSR5Ir5QSVsTDUAg4c1a0YxYw_5kqXiBIRvihXDxxr8BEMfED9ehQBsqOcsR8OPmqFGDCHAnBouwaJZH3fMrsKUvpEQHKSvM-Pa4ntnSlGb9PoDEEODvKiQzFXspm7zShVbujTivheMVeLajuPAvhrtizxGO0k_K0eXTabLQanZPTk17nJHO0r29Hu5Vqd5LgPV8F3KHigb7yRbiAoPlIf7LdS_Zba3-ZzZUHUaE89Ib7rDxqKIVri2r21qFlTmVgi-ukjjX3biHpDxwnhAphZWNMPEIWPrdkzhmS3nmOLdevnq_D6p58vIEYw3nBrP8k9uT6RiN_kejY2QWNMZsxL1puZQe5Z8yZfwILj6naLV43E2MtDYuk-wybZWpj18YORKGRjk7TwJJmQoidmdbh0mP-bDWZcybcctSxWEO6tDRzGr3P3DuWK2WKNLSkSb5T37XLF3YyNXuJUM802BebN8xlqK0s9cCgWASAy2wr6ZEv_4P1tygHG_gLGfqWGhhiKwXinGI6jTFzQ0dZmSppIy4FNFe2aiQokFOIUtCBUtT5eSXdmbXR9CKlEFn5JuFyCREEvaGAwcdeI50woa7mNiXNmvYLuPK-E51aAHOr7QJr2hILJNWC7SobgKKlmqeZfG-ty5q4cIWt_XyAWLGADKD75AdpEWhuoI-yanE0oWVzNpIvIPkcpyDBTup2HjVURRai-Mz7e2XNP0NutcC150KFBSfBeo1NxHqZR76A6BkEV1RR4kb18zfqc-qpltlDRn1nfg8bflFP_7qhQjxBMMC7G8AmApH_-bGeOOHVo88YofGxdpBCC4A_iIKHqXlU6xQnRoGCxGJ8JzBLY0ND_dVgPZm6cy_qHheZaRXea-C4KEQOtzSY30h_QdcDLyiQPekyYNrt99vtaLJkYCjTh_Ov43t98WGu1DI4Oz5-eXk5WlI1l1P2ClnjyJGL4yWAQJuPwU8uxEdU4XgAfy5nA_1HMzqOOZ2b6VdwbH7h2fE5yGB24RitoO2FZsKLCTINYoPhjwlTZj_m8uWezaDC_sQWoMOUioCZ2xgqpa_g_uNqifoN7u9xc6Y0FHj3nyEVXK2MKxnC4HIFZyYe361J780gz0PLxb3OBugGy4vsJMLsaCQt4e7aD4w-eHm3QBkJe8V_RtRHeYwOmnIovSmfRYqbH5HmmnlyJ-JuzAmu77A5hFnmEy9cPDFfz7U8PSx0DAQsrHwqHvkMjrMM4zo0H3zSiNHMY4tVlJilEGPqxbPAfGQ7i8QhXHqAmA9qxpjJHNxkgjk22C9edpXU4HGHVBnyJFWM4s4uH9VqdZpZbeB5sTa95mn_NINLF05FFnAkBJhiEySAgM-4-DLVYRpgSTzMh3USwy2TGvAKotm6sLAxIJYMBbZrJv63SGawOHFkPnO1dtoHJ0xM93HpNrbWTWfqHUs3mp2svJnaOx_UP-1ltxoTffFe9ztZz8KwUcqlsrVvKShao8TZWu_DLaQu-QL-fyPgifG1MVtAdeJergZCrEpsSW6dZhcaNusuS7WTFYt1727FonQJbePpeOKLPH3bwNcIzVrZ8qxgK2dzHjd2YbMch0QB2V8uoMjkUxBINzmEeTjdceNsp7gSDKeGOumZVPLBpO0ctEnUSf7RWc38isubb5y9kL-lXPxLZ1i8-rfJtZiboRC74lDNQLnnYG42Mph6aqJ8rHAQESXetsmGOj8SulxCcZOkekgSLwP3GU30KKVY1wBQTyju6TcJkPuFiDIqFU6gpb_zlqHKiaCYm3-Y21FZaCgD5etXitc3N9fDx7tv18k28cD58RROp_juL4JMmG5adV6OSgABt6C6grRJlwFbKxCET4Ghvqij0TT5FVOUiyCH222SQgt4aT632YSb4fQdjO1zyBAFjK5fmQ-WnCX026xGUKEU84Fa50VHfOxk89jgWzEbrYxKOGvBij3P5LoEKGBl2vchlNapaVCaC4aIIiZIk6cKFHZUFO5RRLXDZ7BuxZMSWBlFYZULdR0cUsegcp0ninlFtsnOrdM89MvIIrwhynEU_YqxCB1R5VhVv9UstKqhyvEv5tBVEdoQbYOT2WERg4RQemDvHE7Xgg24wN6_cGc_S087Oxy_BLLN8AEiUNQbFjH8gkVXTLvNCc6Ez59CVRwVUpQ5tsJXGUVmWr_uyOiCw_oCaGqgn7FreoJdFIy2p90bsbGQRWo6nIZGmbcAbKhyt8C0B0XmT09fM0aIqtsi_TMD6Mwh0cF18Cy5axMpNskrM9T1xQHkwiFrdTabU9ccjlDRBT8Lz0tEZQWPqqEU-iu0ZlytqjHBE1eNAx68ahweueeo0M-NGuPNqmYbPs4vZeLZ335wdkJYHp8MDt_NwYw33w3Xbf2O-A-Fu66lrRJAQlyN142EwhDKDaryT0YZXhMVeldg3rKstq2kNdwXkErzMpl3j9FMUDEfB1jFy_R3BFUYQV1wm1-AluCUvJK4ZVTgZ2BSVGOY_72EDbOcE88cGS6p58bcvuwu-8tYT6oAmOqJ_BW-vA0qSal7_BQf6IajRvP8TrFFQMKAmW-QvjO6lJ6e4ppZvbY8EqVn2vkNsulGgTQ97x1TaEFWZ2Q8GF_XRoLOQkb-4YXOT8Fqt0zgOImMwU9qd56i3ow_6UxyRrr932pDn04Vc88Isq-NfDblr2cEvzCtTaChxR-_pviFK0Rs9-2Xj_Pes85Rq_uGfY_-8mc95ggClBWXOlmjDaR71Or33qCxZ95MzSPKkx_bZMB4PQjqJc-1REOqqFgF6oyAJtCLB9xJ7kXD_DPSatS0gfTk4Iz0OzV9NWb_PSO9bg0aLrAInJgz0ql9bBGjMolnGwHRYxrm1n5vErN48ix5FPNIoYbU86Qil4xgezUDom7jNwKpzmcUPGaLFbgVtCihy4LaL0VnwZmrPe0PJ7Lq269AI95S1v-93f-NKEk-CfkEWxpvAAGr8p-MrDciYknjAj1h9nu_jwzibYjoHDT4H762OAbMNXm3rRfUO0LGCUFW5GU0svyD6nb67ddSm_Ttl6OnRvCv8bG3gesGpIMMT0k85yTmhOFN043DBsygcwoUWcmw9sB9X4LutZvYCgQ3V0-lwJb69UN0FIj2IPxsphsPvTIUrUKKdiFFp5CiW0jRK6Q4KaTob1OcH6NhkviwfiW0M_BEL-IEuC00y4vR09fxPY7dzEzLEJMWGTytggC9TL-xI2AkpDavB4_389D1IGmWQEC4WsAiG2u2SnBI5J680GV14TuVhS_D4VJCUqoidKR9s-qardJqv2OL3rurJXAQKp-xxCtnjRL0mOzS5m5aAVplV2iX1nlzR7tljMCEquKFuS5V2Se7h4oC72DUPEBIah5KmNb_zTIH06pXarPdFTHTrCo-s1ee6jnoQBq1DsOmUzqRtSqe_96htqJ1AIdvHuAEdw6lULuiZbuVY3sZc3zCYvwd-b1qPilBPliE4l0FxYEOW-X9qJ6tW5U5dA5wRNqVvaS6JXoH0OPdaaTiye6UPpfN0nG9fEvTPVTg6xyq7OhUtHPl0rJ3gGDTOQCP3qEs2jxMmdE-lDyHOMVVO5gDlV69qs7WOYwch-hiepUD_LajmUFU_EmYnn3j1WepmP7sCu9GP86PN_9Phv8BQc0X5Q==

Before screenshot:

Screenshot_20260808_042913

After screenshot:

Screenshot_20260808_042949

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Aug 23, 2026
@LocalIdentity
LocalIdentity merged commit eef6747 into PathOfBuildingCommunity:dev Aug 23, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crafted mod stuck in UI

2 participants