Fix Mana-infused staff allowing life reservation - #10283
Open
cupkax wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10273.
Description of the problem being solved:
Mana-infused does not allow life reservation. In-game the gem can be supported by arrogance but is not functional. Secondly, if the player allocates blood magic, the game turns the gem inactive with
no available manaerror.PoB currently allows life reservation for mana-infused staff. This PR prevents life-reservation on the gem and only turns it active if mana can be reserved. I've hard-coded the arrogance support guard to prevent specific hungry loop interaction (probably a better way to fix that).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: