Fix filtering Support gems in SkillsTab#9669
Open
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Fix filtering Support gems in SkillsTab#9669Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Show support gems filter in SkillsTab is still showing exceptional gems like "Invert the Rules" when Non-Exceptional is selected. This PR updates the filtering to also check for tagString "Exceptional". Also when filtering Exceptional Supports, it was only showing the ones with a "plusVersionOf", which hides most of the new gems.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: