Add support for Imbued Supports#9670
Open
Peechey wants to merge 11 commits intoPathOfBuildingCommunity:devfrom
Open
Add support for Imbued Supports#9670Peechey wants to merge 11 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 11 commits intoPathOfBuildingCommunity:devfrom
Conversation
…e else because it's an infestation
…s an imbued don't show imbued label/dropdown for skills from items
update scrollBar in SkillsTab to fit imbued change Clear button to X design of the other gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Full implementation of Imbued Supports, including Importing from Character, Saving and Loading to the XML, and fixing "too many gems in slot" warning. The selection automatically filters for Level 1 Non-Exceptional Support gems. The colour of "Imbued Support:" will follow the application options Positive Values Hex colour.
You are only allowed one imbued support per Slot.
PS: This PR also removes the Variant column in the skillsTab. It happened long enough ago I forgot it was in this branch. If you don't want it in this change, let me know.
After screenshot: