feat: add TS-1080 and TSW-1080 touchpanel support - #1455
Open
jonnyarndt wants to merge 1 commit into
Open
Conversation
Add mctsw1080 and mcts1080 Mobile Control touchpanel types and map them to the Tsw1080 and Ts1080 hardware classes in the touchpanel controller factory. Bump the Crestron SimplSharp SDK packages (Library, ProgramLibrary, Program) from 2.21.90 to 2.21.274 across all projects. The Tsw1080 and Ts1080 device classes do not exist in the SDK prior to 2.21.274, so the SDK bump is required for the new panel types to compile.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Mobile Control touchpanel support for Crestron TS-1080/TSW-1080 panels by introducing new Mobile Control type names and ensuring the solution compiles against the SimplSharp SDK version where those panel classes exist.
Changes:
- Register new Mobile Control type names
mctsw1080andmcts1080and map them toTsw1080/Ts1080constructors in the touchpanel factory. - Bump Crestron SimplSharp SDK package references across the affected projects to
2.21.274to pick up the new panel classes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/PepperDash.Essentials/PepperDash.Essentials.csproj | Bumps Crestron.SimplSharp.SDK.Program to 2.21.274. |
| src/PepperDash.Essentials.MobileControl/Touchpanel/MobileControlTouchpanelController.cs | Adds mctsw1080/mcts1080 type names and tsw1080/ts1080 factory mappings. |
| src/PepperDash.Essentials.MobileControl/PepperDash.Essentials.MobileControl.csproj | Bumps Crestron.SimplSharp.SDK.ProgramLibrary to 2.21.274. |
| src/PepperDash.Essentials.MobileControl.Messengers/PepperDash.Essentials.MobileControl.Messengers.csproj | Bumps Crestron.SimplSharp.SDK.ProgramLibrary to 2.21.274. |
| src/PepperDash.Essentials.Devices.Common/PepperDash.Essentials.Devices.Common.csproj | Bumps Crestron.SimplSharp.SDK.ProgramLibrary to 2.21.274. |
| src/PepperDash.Essentials.Core/PepperDash.Essentials.Core.csproj | Bumps Crestron.SimplSharp.SDK.ProgramLibrary to 2.21.274. |
| src/PepperDash.Core/PepperDash.Core.csproj | Bumps Crestron.SimplSharp.SDK.Library to 2.21.274. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ngenovese11 & @andrew-welker - What are your thoughts regarding this PR as I believe it bumps the Crestron SimplSharp SDK version from 2.21.90 -> 2.21.274. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Mobile Control touchpanel support for the TS-1080 and TSW-1080 panels.
mctsw1080andmcts1080.Tsw1080andTs1080hardware classes in the touchpanel controller factory.Why the SDK bump is required
The
Tsw1080andTs1080device classes were introduced in the Crestron SimplSharp SDK at version 2.21.274. They are not present in the previously referenced 2.21.90. Adding the 1080 panel types therefore requires bumping the SDK package references — the new support cannot compile against the older SDK.All SDK packages are moved in lockstep across every project so the referenced SDK version stays consistent:
Crestron.SimplSharp.SDK.Library2.21.90 -> 2.21.274Crestron.SimplSharp.SDK.ProgramLibrary2.21.90 -> 2.21.274Crestron.SimplSharp.SDK.Program2.21.90 -> 2.21.274Version impact
Minor release (new feature, backward compatible). Existing consumers gain the new panel types; no public API is removed or changed.
Validation
mctsw1080is recognized and constructed at runtime with no type-load errors.