Extend BruteForce search to non-XYZ point types - #6457
Conversation
Signed-off-by: jeevan6996 <jeevanpawar5890@gmail.com>
|
The CI linker failures were caused by Updated |
| if constexpr (!pcl::traits::has_xyz_v<PointT> && has_descriptor_size<PointT>::value) | ||
| return (pcl::make_shared<DefaultFeatureRepresentation<PointT>> ()); | ||
| else | ||
| return (pcl::make_shared<DefaultPointRepresentation<PointT>> ()); |
There was a problem hiding this comment.
Thanks for this pull request. Could you please explain why you did this condition, since none of the other search methods do it like this?
|
Thanks. I checked the other search implementations and they default to This condition is intentional for BruteForce’s new non-XYZ descriptor support: types with |
Summary
Fixes #6421.
Validation
cmake --build /private/tmp/pcl-bruteforce-build-6 --target test_brute_force_searchctest --test-dir /private/tmp/pcl-bruteforce-build-6/test -R brute_force_search --output-on-failuregit diff --check