Chain MicroImpute donor blocks#240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The prior MP replacement build called microimpute one target at a time, so prior imputations were never available as predictors for later income/tax leaves. This PR makes that failure mode test-visible: multi-target regime-aware fits must share one fitted microimpute result, and target 2 must store target 1 in its predictor list.
Verification
env -u UV_FROZEN uv run --python 3.13 --extra dev --extra policyengine ruff check src/microplex_us/pipelines/donor_imputers.py src/microplex_us/variables.py tests/pipelines/test_regime_aware_donor_imputer.py tests/test_variables.pyenv -u UV_FROZEN uv run --python 3.13 --extra dev --extra policyengine pytest -q tests/pipelines/test_regime_aware_donor_imputer.py tests/test_variables.pyenv -u UV_FROZEN uv run --python 3.13 --extra dev --extra policyengine pytest -q tests/test_pe_source_impute_specs.py tests/test_pe_source_impute_engine.pyenv -u UV_FROZEN uv run --python 3.13 --extra dev --extra policyengine pytest -q tests/pipelines/test_zi_qrf_backend.pyenv -u UV_FROZEN uv run --python 3.13 --extra dev --extra policyengine pytest -q tests/pipelines/test_donor_imputer_negative_preservation.py tests/data_sources/test_scf_net_worth_components.py -k "imputer or regime_aware or columnwise"microimpute3.1.0 andZeroInflatedImputer(..., sequential=True)