Fix Pension Credit savings credit formula#1754
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1753.
Summary
is_savings_credit_eligiblestandard_minimum_guarantee, not the fullminimum_guaranteewith additionspension_credit_income, while keepingsavings_credit_incomeas qualifying income for amount AValidation
uv run ruff format --check policyengine_uk/variables/gov/dwp/pension_credit/savings_credit/is_savings_credit_eligible.py policyengine_uk/variables/gov/dwp/pension_credit/savings_credit/savings_credit.pyuv run ruff check policyengine_uk/variables/gov/dwp/pension_credit/savings_credit/is_savings_credit_eligible.py policyengine_uk/variables/gov/dwp/pension_credit/savings_credit/savings_credit.pyuv run policyengine-core test policyengine_uk/tests/policy/baseline/gov/dwp/pension_credit/savings_credit/is_savings_credit_eligible.yaml policyengine_uk/tests/policy/baseline/gov/dwp/pension_credit/savings_credit/savings_credit.yaml -c policyengine_uk-> 7 passedThis was identified by the Axiom UK State Pension Credit section 3 oracle comparison: TheAxiomFoundation/axiom-encode#533 and TheAxiomFoundation/rulespec-uk#11.