Conversation
c167eab to
0ad0219
Compare
jonathanlab
left a comment
There was a problem hiding this comment.
nice, lgtm! wonder if we could do with some docs about this as well
| this.git.raw(["worktree", "add", "-b", branchName, worktreePath, base]), | ||
| this.git.raw([ | ||
| "-c", | ||
| "core.hooksPath=/dev/null", |
There was a problem hiding this comment.
nit: I assume this is to circumvent the husky hooks in the posthog/posthog repository right? Do we want to make it configurable if these hooks are enabled/disabled? Totally up to you
There was a problem hiding this comment.
yes, but not to circumvent, just to delay
we still run these later -- we just skip them here so the worktreeinclude and worktreelink processes can complete first, as the hooks may depend on them (ours do)
|
Also would be awesome if we could let users config this in the Worktree settings page, but thats for another PR :D |
0ad0219 to
36efabf
Compare
|
@jonathanlab agree! if this works out, i'll take another pass to imrpove the UX a bit:
|

Problem
tragically, i think we really should make worktrees work well
Changes
less tragically, i think this small change makes it all better :)
.worktreeincludeand.worktreelinkfilesincludecopies files andlinksymlinks filesHow did you test this?
added these tiny pieces to the main repo, and it all works pretty smoothly: https://app.graphite.com/github/pr/PostHog/posthog/52566