Skip to content

fix(sidebar): always sort the "Other" section to the bottom#2848

Open
rafaeelaudibert wants to merge 1 commit into
mainfrom
posthog-code/sidebar-other-last
Open

fix(sidebar): always sort the "Other" section to the bottom#2848
rafaeelaudibert wants to merge 1 commit into
mainfrom
posthog-code/sidebar-other-last

Conversation

@rafaeelaudibert

Copy link
Copy Markdown
Member

Summary

In the sidebar, the Other section (tasks without a resolvable repository) was being sorted alphabetically alongside the repository sections. It should always sit at the bottom.

This pins the "other" group to the bottom in both sort paths of groupByRepository:

  • the alphabetical fallback (no persisted folder order)
  • the persisted folder-order path

via a small pinOtherLast comparator helper.

Testing

  • Added two tests covering "Other" sorting last in both paths.
  • pnpm --filter @posthog/core test groupTasks → 20 passed.

🤖 Generated with Claude Code

The sidebar's "Other" group (tasks without a resolvable repository) was
sorted alphabetically alongside the repository sections. Pin it to the
bottom in both the alphabetical fallback and the persisted folder-order
path via a `pinOtherLast` comparator helper.

Generated-By: PostHog Code
Task-Id: b931d7a0-becd-4750-a1dd-2bdbe648d63f
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 5bbab33.

@rafaeelaudibert rafaeelaudibert requested a review from a team June 23, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant