fix(sidebar): always sort the "Other" section to the bottom#2848
Open
rafaeelaudibert wants to merge 1 commit into
Open
fix(sidebar): always sort the "Other" section to the bottom#2848rafaeelaudibert wants to merge 1 commit into
rafaeelaudibert wants to merge 1 commit into
Conversation
The sidebar's "Other" group (tasks without a resolvable repository) was sorted alphabetically alongside the repository sections. Pin it to the bottom in both the alphabetical fallback and the persisted folder-order path via a `pinOtherLast` comparator helper. Generated-By: PostHog Code Task-Id: b931d7a0-becd-4750-a1dd-2bdbe648d63f
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the sidebar, the Other section (tasks without a resolvable repository) was being sorted alphabetically alongside the repository sections. It should always sit at the bottom.
This pins the
"other"group to the bottom in both sort paths ofgroupByRepository:via a small
pinOtherLastcomparator helper.Testing
pnpm --filter @posthog/core test groupTasks→ 20 passed.🤖 Generated with Claude Code