feat(folder-picker): remove a folder from recents#2859
Open
richardsolomou wants to merge 1 commit into
Open
Conversation
Add a hover-revealed remove button to each row in the Recent dropdown, gated behind a confirmation dialog since removeFolder also deletes the repo's tasks and worktrees. Generated-By: PostHog Code Task-Id: efb7b41b-2cde-40ff-8bd0-13fae0932ca1
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(folder-picker): remove a folder fro..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No way to remove a folder from the Recent list in the folder picker. The only path was the buried "Danger zone" in
FolderSettingsView.Changes
Add a hover-revealed remove button to each row in the Recent dropdown (
packages/ui/src/features/folder-picker/FolderPicker.tsx). It reuses the existinguseFolders().removeFolderhook. Gated behind a confirmation dialog becauseremoveFolderis destructive: it also deletes the repo's tasks and worktrees.How did you test this?
pnpm --filter @posthog/ui typecheckandbiome linton the file, both clean. Did not verify in the running app (the live dev instance is serving a different checkout).Automatic notifications
Created with PostHog Code