feat: session replay minimum recording duration by ioannisj · Pull Request #482 · PostHog/posthog-android

ioannisj · 2026-04-09T10:16:30Z

💡 Motivation and Context

Adds support for the minimumDurationMilliseconds remote config setting for session replay and follows the implementation as described in PostHog/posthog-ios#548

💚 How did you test it?

📝 Checklist

I reviewed the submitted code.
I added tests to verify the changes.
I updated the docs if needed.
No breaking change or entry added to the changelog.

If releasing new changes

Ran pnpm changeset to generate a changeset file
Added the "release" label to the PR to indicate we're publishing new versions for the affected packages

github-actions · 2026-04-17T09:56:50Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

github-actions · 2026-04-29T10:13:27Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

# Conflicts: # posthog-android/api/posthog-android.api # posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt # posthog/src/main/java/com/posthog/internal/PostHogRemoteConfig.kt

github-actions · 2026-04-29T13:26:52Z

posthog-android Compliance Report

Date: 2026-05-06 08:39:58 UTC
Duration: 2775ms

⚠️ Some Tests Failed

0/16 tests passed, 16 failed

Feature_Flags Tests

⚠️ 0/16 tests passed, 16 failed

View Details

Test	Status	Duration
Request Payload.Request With Person Properties Device Id	❌	251ms
Request Payload.Flags Request Uses V2 Query Param	❌	24ms
Request Payload.Flags Request Hits Flags Path Not Decide	❌	26ms
Request Payload.Flags Request Omits Authorization Header	❌	28ms
Request Payload.Token In Flags Body Matches Init	❌	18ms
Request Payload.Groups Round Trip	❌	18ms
Request Payload.Groups Default To Empty Object	❌	18ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It	❌	16ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False	❌	18ms
Request Payload.Disable Geoip Omitted Defaults To False	❌	17ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key	❌	18ms
Request Lifecycle.No Flags Request On Init Alone	❌	14ms
Request Lifecycle.No Flags Request On Normal Capture	❌	2053ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests	❌	15ms
Request Lifecycle.Mock Response Value Is Returned To Caller	❌	14ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event	❌	13ms

Failures

request_payload.request_with_person_properties_device_id

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_uses_v2_query_param

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_hits_flags_path_not_decide

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_omits_authorization_header

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.token_in_flags_body_matches_init

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_round_trip

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_default_to_empty_object

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.person_properties_distinct_id_auto_populated_when_caller_omits_it

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_false_propagates_as_geoip_disable_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_omitted_defaults_to_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flag_keys_to_evaluate_contains_only_requested_key

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.no_flags_request_on_init_alone

Expected 0 /flags requests, got 1

request_lifecycle.no_flags_request_on_normal_capture

Expected 0 /flags requests, got 1

request_lifecycle.two_flag_calls_produce_two_remote_requests

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.mock_response_value_is_returned_to_caller

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

side_effect_events.get_feature_flag_captures_feature_flag_called_event

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

dustinbyrne

Got through some of this but I have to step away. I'll circle back when I can if nobody else gets to it first!

dustinbyrne · 2026-04-29T21:32:01Z

+ * [PostHogReplayBufferDelegate]. When [PostHogReplayBufferDelegate.isBuffering]
+ * is true, snapshots are routed to the buffer and `flush()` calls are suppressed.
+ */
+public class PostHogReplayQueue internal constructor(


Can this be internal? Does it need to be public?

Fixed and made this internal. It ended up public because PostHogReplayIntegration is already a public class, and PostHogReplayQueue was used in a public method when implementing PostHogReplayBufferDelegate.

PostHogReplayIntegration should be internal as well though? I checked hybrid SDKs, and it seems that this class is not used there directly. So, unless I'm missing something (cc @marandaneto), I would also change replay integration to internal since I think we exposed it publicly accidentally

dustinbyrne · 2026-04-29T21:51:59Z

+        if (bufferDelegate?.isBuffering == true) {
+            bufferQueue.add(event)
+            config.logger.log("Buffered replay event '${event.event}'. Buffer depth: ${bufferQueue.depth}")
+            bufferDelegate?.onReplayBufferSnapshot(this)
+        } else {
+            innerQueue.add(event)
+        }


This is a synchronous write to disk. Perhaps this queue should be constructed with an ExecutorService similar to PostHogQueue and serialize buffer writes through it to avoid blocking the calling thread?

unless the caller is guaranteed to be within an ExecutorService already, then i'd add a comment to make that clear

Updated PostHogReplayQueue to take the replay ExecutorService and serialize buffered disk writes through it, similar to PostHogQueue. The buffering state is also rechecked inside the executor before writing, so events won’t be incorrectly buffered if the minimum-duration threshold flips while the task is queued.

dustinbyrne · 2026-04-29T21:58:18Z

+            // Reset minimum duration buffering state for the new session
+            resetBufferingState()


start is only called once globally afaik, so it seems like this call would be better off in onSessionIdChanged?

Right, we were not resetting buffer onSessionIdChanged. We now track current session id and reset when the session actually changes

marandaneto · 2026-05-05T09:19:29Z

@turnipdabeets pls review!

# Conflicts: # posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt # posthog-android/src/test/java/com/posthog/android/replay/PostHogReplayIntegrationTest.kt

turnipdabeets

LGTM, it might be worth adding a few more tests though. Seems like iOS has happy-path migration coverage (PostHogQueue target, file move, ordering, concurrent writes during migration) that this PR doesn't.

ioannisj added 8 commits April 8, 2026 16:19

feat: add buffer queue

bd04f15

feat: parse remote config

fb1fb29

feat: write up replay integration

828eb8c

fix: do not prune buffer queue

f630ff9

feat: flip buffering switch before draining

6962692

feat: add unit tests

af92495

chore: add changeset

0653129

fix: move with disk operation when migrating

b4d525c

ioannisj added the release label Apr 9, 2026

ioannisj mentioned this pull request Apr 15, 2026

Replay features mobile parity tracker-otron PostHog/posthog#30889

Open

github-actions Bot added the stale label Apr 17, 2026

ioannisj removed the stale label Apr 21, 2026

github-actions Bot added the stale label Apr 29, 2026

ioannisj removed the stale label Apr 29, 2026

ioannisj added 2 commits April 29, 2026 14:04

Merge branch 'main' into feat/min_session_duration

d17dc45

# Conflicts: # posthog-android/api/posthog-android.api # posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt # posthog/src/main/java/com/posthog/internal/PostHogRemoteConfig.kt

fix: ensure migrations run on background thread

ecce86f

ioannisj added 2 commits April 29, 2026 16:27

chore: api dump

0cbcba6

fix:

c09bff0

ioannisj marked this pull request as ready for review April 29, 2026 14:27

ioannisj requested a review from a team as a code owner April 29, 2026 14:27

ioannisj requested review from a team, TueHaulund, fasyy612, ksvat and nicowaltz and removed request for a team April 29, 2026 14:27

fix: visibility

78e7918

fix: api dump

9be3d24

dustinbyrne reviewed Apr 29, 2026

View reviewed changes

dustinbyrne requested a review from a team April 29, 2026 22:01

marandaneto requested a review from turnipdabeets May 5, 2026 09:19

ioannisj added 4 commits May 5, 2026 21:06

fix: make PostHogReplayQueue internal

49982db

fix: serialize replay buffer writes off caller thread

6020594

fix: reset buffer state on session changes

e8611ee

Merge branch 'main' into feat/min_session_duration

69a42bb

# Conflicts: # posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt # posthog-android/src/test/java/com/posthog/android/replay/PostHogReplayIntegrationTest.kt

turnipdabeets approved these changes May 5, 2026

View reviewed changes

ioannisj added 3 commits May 6, 2026 01:15

feat: add more unit tests

4ef1420

Merge branch 'main' into feat/min_session_duration

c41a9dd

fix: build

80f07b4

ioannisj merged commit 006f5d0 into main May 6, 2026
14 checks passed

ioannisj deleted the feat/min_session_duration branch May 6, 2026 08:44

		// Reset minimum duration buffering state for the new session
		resetBufferingState()

Conversation

ioannisj commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

If releasing new changes

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

posthog-android Compliance Report

⚠️ Some Tests Failed

Feature_Flags Tests

Failures

Uh oh!

dustinbyrne left a comment

Choose a reason for hiding this comment

Uh oh!

dustinbyrne Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj May 5, 2026

Choose a reason for hiding this comment

Uh oh!

dustinbyrne Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

marandaneto May 5, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj May 5, 2026

Choose a reason for hiding this comment

Uh oh!

dustinbyrne Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj May 5, 2026

Choose a reason for hiding this comment

Uh oh!

marandaneto commented May 5, 2026

Uh oh!

turnipdabeets left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ioannisj commented Apr 9, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading