Update NRPF for better memory optimization#1433
Merged
Merged
Conversation
1 task
Member
|
Thanks for the contribution @akshatowl ! We shall conduct a review soon. Meanwhile there are some build failures which you can address. I see the DCO action can be resolved as well. |
nitbharambe
reviewed
Jun 11, 2026
figueroa1395
left a comment
figueroa1395
left a comment
Member
There was a problem hiding this comment.
Additional comments and remarks:
- Please take a look at the CI and resolve those complains. I believe I mentioned them in the in-code comments , but double check in case I missed anything.
- CI is complaining about formatting. In order to resolve easily, you can run
uv run pre-commit runand this will re-format for you, among other things. Moreover, if you build from source,uv syncand thenuv run pre-commit runyou will also locally check that the tests pass at the python side; this way you will make sure that your changes in the core make sense throughout the whole pipeline locally. - DCO check is failing and I see you attempted to fix it by looking at the commit history. Unfortunately, in order to fix it, you must amend all the previous commits and add a sign-off to those as well; having one commit signed off is not enough. This means you need to force push (danger mode). I can't do this for you but if you need a hand just ping me.
Finally, this looks very good! And the (unit and validation) tests all passed on the first try. Great job and thank you for the contribution!
Don't hesitate to ping us if you need or want a hand. We'll take another look once you have resolved our initial comments.
nitbharambe
reviewed
Jun 11, 2026
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
I, akshatowl <akshatpandeyplus41@gmail.com>, hereby add my Signed-off-by to this commit: 052f791 Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
akshatowl
force-pushed
the
fix/nrpf-update
branch
from
ad70136 to
373dea6
Compare
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Member
|
Hi @akshatowl, The PR is in good shape. Please fix the last CI build errors. Then we can consider to merge. |
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
Signed-off-by: Akshat Pandey <akshatpandeyplus41@gmail.com>
TonyXiang8787
approved these changes
Jun 17, 2026
TonyXiang8787
left a comment
TonyXiang8787
left a comment
Member
There was a problem hiding this comment.
Hi @akshatowl,
Thanks again for your great contribution. The PR is ready to go into the merge queue.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing the linear allocations and splitting computation into real and imaginary components, attempting to address #1422