sssss - #62
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new developer-facing utilities to improve observability and agent-style composition in LargeLanguageModels, alongside a significant documentation refresh (README + new docs files) and dependency lockfile updates.
Changes:
- Introduces two actor-based, in-memory logging/storing utilities for LLM request failures (
LLMErrorLogger,FailedLLMResponseStore) plusLLMRequestHandlingconvenience wrappers. - Adds a simple sequential Observer → Research → Decision agent pipeline abstraction (
LLMAgentPipeline). - Expands and reorganizes project documentation (README overhaul + new
docs/files, contributing guide, changelog, PR template).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/LargeLanguageModels/Intramodular/LLMs/Logging/LLMErrorLogger.swift | Adds an actor-backed error logger and a complete(...loggingErrorsTo:) wrapper. |
| Sources/LargeLanguageModels/Intramodular/LLMs/Logging/FailedLLMResponseStore.swift | Adds an actor-backed store for failed chat prompts with JSONL export and a complete(...recordingFailuresIn:) wrapper. |
| Sources/LargeLanguageModels/Intramodular/LLMs/Agents/LLMAgentPipeline.swift | Introduces a basic multi-stage agent pipeline and default stages. |
| README.md | Major doc restructure: architecture overview, dependency graph, roadmap revamp, and more. |
| Package.resolved | Updates dependency lock revisions/hashes. |
| docs/README.md | Adds a documentation index page. |
| docs/ARCHITECTURE.md | Adds architecture/layering documentation and a dependency graph. |
| CONTRIBUTING.md | Adds contributor setup/process guidance. |
| CHANGELOG.md | Introduces changelog with initial [Unreleased] notes. |
| .github/PULL_REQUEST_TEMPLATE.md | Adds a PR template/checklist aligned with docs + layering expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@5hy7xz92nd-oss @copilot @copilot @Rabbitsync @WEAREONE10BILLION @manus @MANUSWEAREONE10BILLION @patpat @grok @openai @agent @agent Coordinator
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Suppressed comments (6)
Sources/LargeLanguageModels/Intramodular/LLMs/Logging/FailedLLMResponseStore.swift:75
exportAsJSONL()is new behavior that’s easy to regress (date encoding, line separation, JSON validity per line). There are existing unit tests underTests/LargeLanguageModels; consider adding a focused test that records a couple of entries and asserts each line decodes back intoFailedChatResponse.
public func exportAsJSONL() throws -> String {
let encoder = JSONEncoder()
encoder.outputFormatting = []
encoder.dateEncodingStrategy = .iso8601
return try _entries
.map { try String(decoding: encoder.encode($0), as: UTF8.self) }
.joined(separator: "\n")
}
README.md:2
- The GitHub admonition syntax requires the marker to start immediately after
>(e.g.> [!IMPORTANT]). With the emoji prefix (> 🕴️[!IMPORTANT]), the admonition likely won’t render as an IMPORTANT callout.
> 🕴️[!IMPORTANT]
> This package is presently in its alpha stage of development (2026-03-04).
Sources/LargeLanguageModels/Intramodular/LLMs/Logging/LLMErrorLogger.swift:80
- The doc comment says
loggingErrorsTodefaults toLLMErrorLogger.shared, but the method signature requires the argument. This is a doc/API mismatch and makes the convenience API harder to use.
public func complete<Prompt: AbstractLLM.Prompt>(
_ prompt: Prompt,
parameters: Prompt.CompletionParameters,
loggingErrorsTo logger: LLMErrorLogger
) async throws -> Prompt.Completion {
Sources/LargeLanguageModels/Intramodular/LLMs/Logging/LLMErrorLogger.swift:55
LLMErrorLoggerstores entries indefinitely in an in-memory singleton. In long-running processes this can grow without bound, andpromptDescriptionmay include sensitive prompt content depending onPrompt’sCustomStringConvertible/CustomDebugStringConvertiblebehavior. Consider adding a retention policy (e.g. max entry count / ring buffer) and/or a redaction strategy for prompt details.
/// Append a new entry to the log.
public func log(_ entry: AbstractLLM.ErrorLogEntry) {
_entries.append(entry)
}
Sources/LargeLanguageModels/Intramodular/LLMs/Logging/FailedLLMResponseStore.swift:56
FailedLLMResponseStoreretains full chat prompts (prompt.messages) indefinitely in an in-memory singleton, andexportAsJSONL()will serialize that content. This can unintentionally persist secrets/PII and can grow memory usage without bound. Consider adding opt-in/redaction (e.g. strip user content, hash, or truncate) and a retention policy (max entries).
/// Append a new failed-response record.
public func record(_ entry: AbstractLLM.FailedChatResponse) {
_entries.append(entry)
}
Sources/LargeLanguageModels/Intramodular/LLMs/Agents/LLMAgentPipeline.swift:145
- The new agent pipeline wiring (Observer → Research → Decision) has no unit coverage. Since
LLMAgentStage.processandAgentPipeline.runare pure orchestration, consider adding a test with a lightweightLLMRequestHandlingstub that returns deterministic completions, then assert stage chaining and outputs.
public func run(input: String) async throws -> AgentPipelineResult {
let observation = try await observer.process(input: input, using: llm)
let research = try await researcher.process(input: observation, using: llm)
let decision = try await decisionMaker.process(input: research, using: llm)
return AgentPipelineResult(
input: input,
observation: observation,
research: research,
decision: decision
)
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@5hy7xz92nd-oss @claude @codex @grok
@openai @patpat @weareone10billion @Rabbitsync
|
@5hy7xz92nd-oss @claude @codex @grok |
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@5hy7xz92nd-oss @claude @codex @grok
@openai @patpat @weareone10billion @Rabbitsync execute
…t/1k-repo-decentralized-architecture
…kflow (#50) (#56) (#200) (#257) * Document package architecture, dependency graph, and contribution workflow (#50) (#58) * Document package architecture, dependency graph, and contribution workflow (#50) (#56) (#200) * Document package architecture, dependency graph, and contribution workflow (#50) (#56) (#258)
…earch-and-decision-flow
…check-feature-or-bug
…eck-feature-or-bug
…element-events Add repo research plan and workflow roles to docs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
#537) ## Summary <!> 🕴️[!IMPORTANT] > This package is presently in its alpha stage of development (2026-03-04). #### Supported Platforms SPM platforms from [`Package.swift`](Package.swift): **iOS 16+**, **macOS 13+**, **tvOS 16+**, **visionOS 1+**, **watchOS 9+**. <p align="left"> <picture> <source media="(prefers-color-scheme: dark)" srcset="Images/macos.svg"> <source media="(prefers-color-scheme: light)" srcset="Images/macos-active.svg"> <img alt="macOS" src="Images/macos-active.svg" height="24"> </picture> <picture> <source media="(prefers-color-scheme: dark)" srcset="Images/ios.svg"> <source media="(prefers-color-scheme: light)" srcset="Images/ios-active.svg"> <img alt="iOS" src="Images/ios-active.svg" height="24"> </picture> <picture> <source media="(prefers-color-scheme: dark)" srcset="Images/ipados.svg"> <source media="(prefers-color-scheme: light)" srcset="Images/ipados-active.svg"> <img alt="iPadOS" src="Images/ipados-active.svg" height="24"> </picture> <picture> <source media="(prefers-color-scheme: dark)" srcset="Images/tvos.svg"> <source media="(prefers-color-scheme: light)" srcset="Images/tvos-active.svg"> <img alt="tvOS" src="Images/tvos-active.svg" height="24"> </picture> <picture> <source media="(prefers-color-scheme: dark)" srcset="Images/watchos.svg"> <source media="(prefers-color-scheme: light)" srcset="Images/watchos-active.svg"> <img alt="watchOS" src="Images/watchos-active.svg" height="24"> </picture> </p> Also targets **visionOS** (badge art not yet in `Images/`). # AI The definitive, open-source Swift framework for interfacing with generative AI. ## Documentation - [Architecture](docs/ARCHITECTURE.md) - [Contributing](CONTRIBUTING.md) - [Changelog](CHANGELOG.md) ## Table of Contents - [Architecture Overview](#architecture-overview) - [Dependencies](#dependencies) - [Installation](#installation) - [Usage](#usage) - [Import the framework](#import-the-framework) - What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com>
Added a template for creating a custom agent with instructions. Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
|
Copilot pull request summaries Copilot in GitHub Desktop Agentic features Copilot CLI GitHub Copilot app Copilot cloud agent Third-party coding agents (public preview) Copilot code review Several tools in Copilot code review are in public preview and subject to change. See About GitHub Copilot code review. Agent mode in IDEs Features for customization Copilot Spaces Custom instructions Copilot Memory (public preview) Prompt files MCP servers Agent skills Custom agents Features for administrators Policy management Access management Usage data Audit logs File exclusions Next steps |
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
Copilot pull request summaries
AI-generated summaries of the changes that were made in a pull request, which files they impact, and what a reviewer should focus on when they conduct their review. See Creating a pull request summary with GitHub Copilot.
Copilot in GitHub Desktop
Automatically generate commit messages and descriptions with Copilot in GitHub Desktop based on the changes you make to your project.
Agentic features
These features can work autonomously without direct human supervision. However, they typically need human approval to perform sensitive actions, such as running commands in a developer's terminal or merging a pull request.
Copilot CLI
A command line interface that lets you use Copilot in your terminal. Use the CLI to add features or fix bugs, then create a pull request. Start Copilot working on a task in your terminal, then continue working in the same session on GitHub.com, or on your mobile. See About GitHub Copilot CLI.
GitHub Copilot app
A desktop application for agent-driven development. From the app, you can run multiple agent sessions in parallel across your repositories, manage issues and pull requests, and set up automations to run tasks on a schedule. See About the GitHub Copilot app.
Copilot cloud agent
An autonomous AI agent that can research a repository, create an implementation plan, and make code changes on a branch. You can review the diff, iterate, and create a pull request when you're ready. You can also assign a GitHub issue to Copilot or ask it to open a pull request directly to complete a task. See GitHub Copilot cloud agent.
Third-party coding agents (public preview)
You can use third-party coding agents alongside Copilot cloud agent. Third-party agents are subject to the same security protections, mitigations, and limitations as Copilot cloud agent. See About third-party coding agents.
Copilot code review
AI-generated code review suggestions to help you write better code. See Using GitHub Copilot code review.
Several tools in Copilot code review are in public preview and subject to change. See About GitHub Copilot code review.
Agent mode in IDEs
Allow Copilot to work autonomously in the IDE. Copilot will determine which files to make changes to, offer code changes and terminal commands for the user's approval, and iterate to remediate issues until the original task is complete.
Features for customization
These features can be used to add context to Copilot and improve its performance. For a comparison of when to use each feature, see Copilot customization cheat sheet.
Copilot Spaces
Organize and centralize relevant content—like code, docs, specs, and more—into Spaces that ground Copilot’s responses in the right context for a specific task. See About GitHub Copilot Spaces.
Custom instructions
Enhance responses by providing contextual details on your preferences, tools, and requirements. See About customizing GitHub Copilot responses.
Copilot Memory (public preview)
Copilot can deduce and store useful information about a repository, which Copilot cloud agent and Copilot code review can use to improve the quality of their output when working in that repository. For more information, see About GitHub Copilot Memory.
Prompt files
Build and share reusable prompt instructions with additional context. A prompt file is a Markdown file, stored in your workspace, that mimics the existing format of writing prompts. See About customizing GitHub Copilot responses.
MCP servers
You can configure Model Context Protocol (MCP) servers for many Copilot features, giving Copilot access to external tools or data sources. See About Model Context Protocol (MCP).
Agent skills
Create folders of instructions, scripts, and resources that Copilot can load when relevant to improve its performance in specialized tasks. See About agent skills.
Custom agents
Create specialized versions of Copilot cloud agent with access to specific tools, instructions, and MCP servers. See About custom agents.
Features for administrators
The following features are available to organization and enterprise owners with a Copilot Business or Copilot Enterprise plan.
Policy management
Manage policies for Copilot in your organization or enterprise. See Managing policies and features for GitHub Copilot in your organization and Managing policies and features for GitHub Copilot in your enterprise.
Access management
Enterprise owners can specify which organizations in the enterprise can use Copilot, and organization owners can specify which organization members can use Copilot. See Managing access to GitHub Copilot in your organization and Managing access to Copilot in your enterprise.
Usage data
Review Copilot usage data within your organization or enterprise to inform how to manage access and drive adoption of Copilot. See Reviewing user activity data for GitHub Copilot in your organization and Viewing Copilot license usage in your enterprise.
Audit logs
Review audit logs for Copilot in your enterprise to understand what actions have been taken and by which users. See Reviewing audit logs for GitHub Copilot.
File exclusions
Configure Copilot to ignore certain files. This can be useful if you have files that you don't want to be available to Copilot. See Excluding content from GitHub Copilot.
Next steps
To learn more about the plans available for GitHub Copilot, see Plans for GitHub Copilot.
To start using Copilot, see Setting up GitHub Copilot.
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 117 out of 128 changed files in this pull request and generated 43 comments.
Suppressed comments (1)
Sources/AI/AnySpeechSynthesisRequestHandling.swift:38
- Equality compares only cached integer hash values. Distinct client objects can have colliding hashes and will then compare equal, violating identity semantics. Store and compare
ObjectIdentifieritself, and use it for hashing.
public static func == (lhs: AnySpeechSynthesisRequestHandling, rhs: AnySpeechSynthesisRequestHandling) -> Bool {
lhs._hashValue == rhs._hashValue
| import xAI | ||
|
|
||
| public var xAI_API_KEY: String { | ||
| "xai-iukwcbTFm3HCyuJVq7U5c0c9LKHJ0uhnGIsiOyn4Qu0zxSH3g1ULDSkaCHHoDQnX9tsV5cSCWom0HosP" |
| @_exported import LargeLanguageModels | ||
| @_exported import SwallowMacrosClient |
| self.logitBias = nil | ||
| self.logprobs = nil | ||
| self.topLogprobs = nil | ||
| self.seed = nil | ||
| } |
| dependencies: [ | ||
| "AI", | ||
| "Swallow" | ||
| ], |
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/vmanot/CorePersistence.git", branch: "main"), | ||
| .package(url: "https://github.com/vmanot/Media", branch: "main"), |
| public var _availableModels: [ModelIdentifier]? { | ||
| return TogetherAI.Model.allCases.map({ $0.__conversion() }) | ||
| } |
| name: | ||
| description: |
| public var stabilize: Bool | ||
| public var motionBucketId: Int // 0-127 | ||
| public var conditioningAugmentation: Double // 0.01-0.1 |
| // | ||
|
|
||
| import CorePersistence | ||
| import SwiftUIX |
| if let base = (base as? any Named) { | ||
| return base.name.description | ||
| } else { | ||
| return base.rawValue | ||
| } |
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- ## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
## Summary <!-- What does this PR change and why? --> ## Type of change - [ ] Bug fix - [ ] New provider / API surface - [ ] Refactor - [ ] Documentation - [ ] Tests / CI - [ ] Other ## Checklist - [ ] Builds with the package’s supported Xcode/Swift versions - [ ] Tests added or updated when behavior changes - [ ] No secrets or API keys committed - [ ] Docs updated if products, targets, public API, or dependencies changed: - [ ] `README.md` - [ ] `docs/ARCHITECTURE.md` (graph / tables) - [ ] `CHANGELOG.md` (`[Unreleased]`) - [ ] Layering respected (providers → `LargeLanguageModels` → `CoreMI`; avoid new provider→provider deps) ## Test plan <!-- How did you verify? Unit tests, manual API calls, platforms… --> ## Related issues <!-- Fixes #… --> --------- Signed-off-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com> Co-authored-by: Vatsal Manot <vatsal.manot@yahoo.com> Co-authored-by: Jared Davidson (Archetapp) <archetapp@gmail.com> Co-authored-by: Akshat Patel <akshat.patel16@gmail.com> Co-authored-by: Purav Manot <manot.purav@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NatashaTheRobot <nmurashev@gmail.com>
sssss@5hy7xz92nd-oss @claude @codex @grok
@openai @patpat @weareone10billion @Rabbitsync.
gh pr checkout 62 gh pr checkout 62