Merged
Conversation
… bucketing - Remove hidden `g` key requirement — cursor (←/→) is always active across setting columns + a metric column; Enter toggles grouping on settings or opens a metric picker on the avg column - Add MetricSelectorScreen modal for choosing any numeric metric from results - Store raw metric_values in RunOverviewStats for per-metric distribution - Adaptive bucketing (_metric_bucket_counts) for non-reward metrics with red→green gradient; min/max columns replace =0/=1 for non-reward - Use ratio=1 for setting columns so Rich handles layout; fixes column truncation at various terminal widths - Use compact formatting (_format_compact_metric) for non-reward values Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove MetricSelectorScreen modal in favor of a Select widget embedded in the compare screen panel - Enter on the avg column opens the dropdown directly via action_show_overlay - Focus returns to the screen after selection so Enter works normally on setting columns Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Discard "reward" from metric_names before prepending it, since _extract_numeric_metric_values can also extract a "reward" key from record["metrics"] or record["info"]["reward_signals"]. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
_reward_style uses hardcoded 0-1 thresholds that are meaningless for arbitrary metrics. Now only applied when metric_key is "reward"; other metrics get plain bold styling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 88865e7. Configure here.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
vf-tui now is always in group mode when we enter compare model (previously, it went v->g, now it's just v). There:
Pressing
vwill immediately get us into group mode:Pressing enter on any of the arg columns still allows us to group by the unique values of that arg:
But now, it's also possible to select the "avg reward" column (renamed from just "avg"):
Pressing enter here doesn't group by the unique values (because that doesn't make any sense). Instead, it allows us to select a different metric:
And then selecting one will show the results of that metric like the reward before:
Type of Change
Testing
uv run pytestlocally.Checklist
Note
Medium Risk
Adds new metric-selection and bucketing logic to the comparison TUI, changing how comparison tables are computed and navigated; main risk is UI/regression in table layout and metric aggregation/formatting across diverse value ranges.
Overview
Extends the run comparison TUI to compare any numeric metric, not just reward, via a new
Selectdropdown and a metric-aware avg/min/max + distribution “mix” display.Refactors comparison navigation to a single cursor model (left/right/enter) that toggles grouping on setting columns or opens the metric selector when the metric column is selected, and updates copy/export to reflect the chosen metric.
Reviewed by Cursor Bugbot for commit f99c6d2. Bugbot is set up for automated code reviews on this repo. Configure here.