Fix goal progress verification#1759
Conversation
Implemented `outside click` and `Escape key` handling for improved sheet dismissal UX and accessibility.
…e-handling Implement close functionality for DailyBreakdownSheet
The for loop that was setting up route mocks (lines 176-183) was executing at module load time instead of during test setup. This caused Playwright to try to execute page.route() outside of a test context, triggering the error 'test.beforeEach() to be called here'. Moving the loop inside the beforeEach hook ensures all route setup happens at the correct time during test initialization.
|
@Rohith31-WD is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
This PR has merge conflicts with |
|
This PR is still in draft status. Please mark it as ready for review when it's complete. |
|
This PR is still in Draft and has merge conflicts with
|
|
This PR has merge conflicts with git fetch origin
git rebase origin/mainOnce you resolve the conflicts and CI passes, we can review for merge. |
|
Hi! This PR has merge conflicts with the git fetch upstream
git rebase upstream/main
# resolve any conflicts
git push --force-with-leaseIf you're no longer working on this, let us know and we can close it. Thanks! |
|
This PR has merge conflicts with the main branch. Please rebase your branch on latest main and resolve the conflicts so it can be reviewed and merged. |
Summary
commitsandprs)Root cause
The PATCH endpoint validated that
currentwas numeric and within target bounds, but it trusted the client as the source of truth for goals whose progress should come from GitHub activity.Validation
npm exec -- tsc --noEmitnpm exec -- vitest run test/goals-patch-progress.test.tscould not start in this sandbox because the local runner's esbuild subprocess was blocked withspawn EPERM.Fixes #1753