Skip to content

Fix goal progress verification#1759

Draft
Rohith31-WD wants to merge 8 commits into
Priyanshu-byte-coder:mainfrom
Rohith31-WD:codex/fix-goal-progress-verification
Draft

Fix goal progress verification#1759
Rohith31-WD wants to merge 8 commits into
Priyanshu-byte-coder:mainfrom
Rohith31-WD:codex/fix-goal-progress-verification

Conversation

@Rohith31-WD

Copy link
Copy Markdown
Contributor

Summary

  • Reject client-supplied progress updates for GitHub-synced goals (commits and prs)
  • Keep manual progress updates available for non-GitHub goals
  • Add regression tests for synced-goal PATCH behavior

Root cause

The PATCH endpoint validated that current was numeric and within target bounds, but it trusted the client as the source of truth for goals whose progress should come from GitHub activity.

Validation

  • npm exec -- tsc --noEmit
  • npm exec -- vitest run test/goals-patch-progress.test.ts could not start in this sandbox because the local runner's esbuild subprocess was blocked with spawn EPERM.

Fixes #1753

Implemented `outside click` and `Escape key` handling for improved sheet dismissal UX and accessibility.
…e-handling

Implement close functionality for DailyBreakdownSheet
The for loop that was setting up route mocks (lines 176-183) was executing at module load time instead of during test setup. This caused Playwright to try to execute page.route() outside of a test context, triggering the error 'test.beforeEach() to be called here'.

Moving the loop inside the beforeEach hook ensures all route setup happens at the correct time during test initialization.
@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

@Rohith31-WD is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 31, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Rohith31-WD Rohith31-WD changed the title [codex] Fix goal progress verification Fix goal progress verification May 31, 2026
@github-actions github-actions Bot added the type:bug GSSoC type bonus: bug fix label May 31, 2026
@github-actions github-actions Bot added the type:devops GSSoC type bonus: devops (+15 pts) label May 31, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder added level2 GSSoC Level 2 - Medium complexity (25 points) gssoc:approved GSSoC: PR approved for scoring labels May 31, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

This PR has merge conflicts with main. Please rebase:

git fetch origin
git rebase origin/main
# fix conflicts, then:
git push --force-with-lease

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

This PR is still in draft status. Please mark it as ready for review when it's complete.

@Priyanshu-byte-coder Priyanshu-byte-coder added the level:intermediate GSSoC: Intermediate difficulty (35 pts) label Jun 3, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

This PR is still in Draft and has merge conflicts with main. Please:

  1. Finish the implementation
  2. Rebase on main to resolve conflicts
  3. Mark as ready for review when done

@Priyanshu-byte-coder Priyanshu-byte-coder added the quality:clean GSSoC: Clean quality multiplier (×1.2) label Jun 4, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

This PR has merge conflicts with main due to recent changes. Please rebase to continue:

git fetch origin
git rebase origin/main

Once you resolve the conflicts and CI passes, we can review for merge.

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Hi! This PR has merge conflicts with the main branch. Could you please rebase or merge main into your branch to resolve them? We'd love to get this merged! 🚀

git fetch upstream
git rebase upstream/main
# resolve any conflicts
git push --force-with-lease

If you're no longer working on this, let us know and we can close it. Thanks!

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

This PR has merge conflicts with the main branch. Please rebase your branch on latest main and resolve the conflicts so it can be reviewed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:intermediate GSSoC: Intermediate difficulty (35 pts) level2 GSSoC Level 2 - Medium complexity (25 points) quality:clean GSSoC: Clean quality multiplier (×1.2) type:bug GSSoC type bonus: bug fix type:devops GSSoC type bonus: devops (+15 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Goal progress can be arbitrarily modified through the PATCH endpoint without verification against actual GitHub activity

2 participants