fix(notification-bell): improve notification API error handling#2253
Conversation
|
@S-MOHAMMED-ISMAIL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
The failing CI checks appear unrelated to this change. This PR only modifies The failing tests are in:
No changes were made to those areas in this PR. |
|
The error handling logic is good, but the indentation is broken throughout the new code — it's flush-left instead of matching surrounding indentation. Please fix the formatting and resubmit. |
Summary
Fixes #1659
Improves NotificationBell error handling by preventing notification-related API failures from being silently ignored.
Type of Change
What Changed
How to Test
/api/notificationsrequestPATCH) requestExpected result:
Screenshots / Recordings
N/A
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Additional Context
The repository currently has unrelated TypeScript and environment issues on the latest upstream branch that prevent a clean local type-check run. This change is isolated to
src/components/NotificationBell.tsxand directly addresses Issue #1659 by surfacing notification API failures to users instead of silently ignoring them.