fix: resolve double response body read in handleSync #2284
Open
just-tanvi wants to merge 1 commit into
Open
Conversation
|
@just-tanvi is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
handleSyncfunction where the fetch response body was being consumed twice when the API returned an HTTP429 Too Many Requestsstatus code.Previously, the first
.json()call inside the initialtry/catchconsumed the response stream, causing a subsequent.json()call in the429status check block to throw aTypeError: body stream already read. This swallowed the intended rate limit error message and resulted in a generic"Network error. Failed to sync goals."being shown to the user.Changes Made
handleSyncinsrc/components/GoalTracker.tsxto read the response body exactly once into anerrDatavariable.errDatato properly branch onres.status(429,401,502, etc.) without re-reading the stream.msgvariable).test/GoalTracker.test.tsexpectations ("Sync failed. Please try again.").Testing
test/GoalTracker.test.tspass successfully.tsc --noEmit) passes with zero errors.closes #2283