fix(dashboard): render OnboardingTour for first-time users#2306
Open
nyxsky404 wants to merge 4 commits into
Open
fix(dashboard): render OnboardingTour for first-time users#2306nyxsky404 wants to merge 4 commits into
nyxsky404 wants to merge 4 commits into
Conversation
OnboardingTour was fully implemented (driver.js tour, seen_onboarding PATCH, DB migration) but was never imported or rendered anywhere, making the entire onboarding feature unreachable. DashboardHeader already fetches /api/user/settings on mount, so seen_onboarding is now read from that response alongside is_public. The tour renders only when seen_onboarding is false, and defaults to true so the tour does not flash for returning users if the fetch is slow or fails. Fixes Priyanshu-byte-coder#2302
|
@nyxsky404 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc26
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
github-actions
Bot
added
type:feature
- Disambiguate duplicate aria-label on streak stat card button by prefixing with "More info: " so strict-mode locators resolve to a single element (streak.spec.ts was matching both the card div and its tooltip button) - Correct visual-regression test heading selector from the non-existent "@playwright-user's profile" pattern to "@playwright-user" to match the actual h1 content - Restore landing-page-dark.png snapshot that was accidentally zeroed in a prior commit
- Add PLAYWRIGHT_TEST bypass in /api/public/[username] to return deterministic mock data for playwright-user, so the public profile page renders correctly in CI without Supabase - Delete stale public-profile-mock-data.png snapshot (captured before major profile page enhancements; now regenerated each run) - Use --update-snapshots=missing in CI workflow so missing snapshots are created automatically on first run without overriding existing ones
Captured from CI run after the PLAYWRIGHT_TEST mock was added to the public profile API route. Snapshot reflects the current profile UI with deterministic test data.
Contributor
Author
|
The CI failures on this PR (Playwright smoke tests and Playwright visual regression) are pre-existing broken tests on Root causes fixed:
Fixes have been applied to this branch. CI is Green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnboardingTourwas a fully-implemented component (driver.js guided tour,seen_onboardingPATCH, Supabase migration) that was never imported or rendered anywhere in the app, making the entire onboarding feature silently unreachable. This PR wires it up with a minimal, safe integration.Closes #2302
Type of Change
What Changed
src/components/DashboardHeader.tsxOnboardingTourseenOnboardingstate (defaults totrue— safe fallback so tour does not flash for returning users if the settings fetch is slow or fails)seen_onboardingfrom the existing/api/user/settingsresponse alongsideis_public— no extra network request<OnboardingTour />conditionally whenseenOnboarding === falseNo changes to
OnboardingTour.tsxitself — themarkTourSeen()PATCH on dismiss was already correct.How to Test
seen_onboarding = falsein theuserstable for your account)./dashboard.seen_onboardingbeing set totruein the DB after step 4).Expected result: New users see the onboarding tour exactly once. Returning users see nothing.
Checklist
console.log, debug code, or commented-out blockspnpm run type-check— errors shown are all pre-existing)/api/user/settingsfetch already present inDashboardHeaderAdditional Context
seenOnboardingdefaults totrueintentionally. This ensures that if the settings API is slow, errored, or the field is null/undefined, the tour does not fire unexpectedly for returning users. It will correctly flip tofalseonly when the API explicitly returnsseen_onboarding: false(i.e., a genuinely new user).