Skip to content

Update filtering selectors #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaolaPellegrini merged 1 commit into from
Dec 1, 2025
Merged

Update filtering selectors #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions selectors/filtering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
export default {
openFilter: '[id="pm-table-column-{col}"] button',
//openFilter: '[id="pm-table-column-{col}"] button',
columnHeader: '[id="-column-{col}"] [class="pm-table-column-header"]',
gearIcon: '[class="jumbotron jumbotron-fluid"]',
filterForm: '[class="pm-filter-form"]',
//filterForm: '[class="pm-filter-form"]',
filterFooterBtns: '[class="pm-filter-form"] fieldset',
tableRequest: '[class="pm-table-container"]',
/*new filteringV1
//new filteringV1

@cursor cursor Bot Dec 1, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Selector change breaks column replacement in Filtering class

The openFilter selector changed from '[id="pm-table-column-{col}"] button' (with {col} placeholder) to '[class="pm-table-ellipsis-column"] [class="pm-table-column-header"]' (no placeholder). The Filtering class in pages/filtering.js still calls selectors.openFilter.replace("{col}", column), but since the new selector lacks {col}, the replacement has no effect. All columns will use the identical selector regardless of the column parameter, causing filtering to target the wrong elements or behave unexpectedly.

Fix in Cursor Fix in Web

openFilter: '[class="pm-table-ellipsis-column"] [class="pm-table-column-header"]',
threeDots: '.pm-table-ellipsis-column button',
modalFilter: '[class="pm-filter-form"]',
Expand All @@ -15,5 +15,5 @@ export default {
valueFilter: '[data-cy="pmFilterFormArea"] [data-cy="value{row}"]',
removeButtonModal: '[data-cy="pmFilterFormArea"] [data-cy="buttonRemove{row}"]',
addNewFilterButton: '[class="btn pm-filter-form-button btn-light btn-sm"] rect[fill="#D9D9D9"]'
*/

};