Skip to content

FOUR-28033: Multitenat - Oops!, in the default screen interstitial.#8767

Draft
eiresendez wants to merge 1 commit intodevelopfrom
task/FOUR-28033
Draft

FOUR-28033: Multitenat - Oops!, in the default screen interstitial.#8767
eiresendez wants to merge 1 commit intodevelopfrom
task/FOUR-28033

Conversation

@eiresendez
Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

FOUR-28033: Multitenat - Oops!, in the default screen interstitial.
Ticket: https://processmaker.atlassian.net/browse/FOUR-28033

Start Event and task interstitial selectors were auto-resolving the hidden system fallback screen, which exposed an invalid Open Screen link and made the fallback look like an editable selection.

  1. In ProcessMaker, create or open a process and add a Start Event.
  2. Open the Start Event settings and enable the interstitial option.
  3. Observe that the Screen Interstitial field is prefilled and shows an Open Screen link.
  4. Click Open Screen and the app navigates to a 404/Oops page because the fallback system interstitial is not editable through the web screen-builder route.

Solution

  • Updated the modeler interstitial selectors to stop requiring an explicit screen assignment, so an empty selection now correctly means runtime fallback.
  • Removed the auto-exposed default interstitial from the Start Event and task interstitial selectors by excluding the system interstitial key from selectable options.
  • Updated ScreenSelect so Open Screen is only shown for selectable/editable screens, preventing the hidden default interstitial from rendering an invalid editor link.

How to Test

  1. Open the modeler on a process in this branch, select a Start Event, and open its settings. Confirm the Screen Interstitial field is empty by default and no Open Screen link is shown.
  2. Search the Screen Interstitial dropdown and confirm the default system interstitial is not listed as a selectable screen.
  3. Assign a normal tenant-created display screen as the interstitial and confirm the Open Screen link appears and opens that screen builder correctly.
  4. Optionally run ./node_modules/.bin/eslint resources/js/processes/modeler/components/inspector/ScreenSelect.vue to verify the shared selector change; existing baseline lint errors remain in Interstitial.vue and TaskInterstitial.vue outside this ticket’s functional change.

Related Tickets & Packages

@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant