FOUR-26363 | +Case Pagination Is Not Working Correctly#8896
FOUR-26363 | +Case Pagination Is Not Working Correctly#8896mcraeteisha wants to merge 4 commits into
Conversation
Add a new method to handle changing the number of items displayed per page. The method adjusts the current page number if necessary to ensure it doesn't exceed the total number of items, and triggers a data fetch with the updated pagination settings.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
eiresendez
left a comment
There was a problem hiding this comment.
👍 👍 Working as expected!
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34069781 | Triggered | Generic Password | 4d6f281 | resources/views/auth/passwords/reset.blade.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
|
QA server K8S was successfully deployed https://ci-91e619443e.engk8s.processmaker.net |
|
Please note that the security check failure by GitGuardian comes from |





Issue
Ticket: FOUR-26363
This PR fixes the +Case modal per-page selector so that switching between 15 / 30 / 50 immediately refreshes the visible process list.
Solution
requestModal.vueinheritschangePerPage()fromdatatableMixin, which readsthis.data.meta.totalto clamp the current page. But this component never assignsthis.data;fetch()only writes the response intothis.$refs.listProcess.dataandthis.processes. Sothis.data.metawasundefined, the shared handler threw before reachingthis.fetch(), and the list never refreshed.The solution was to override
changePerPage(value)inresources/js/components/requests/requestModal.vueto read the total fromthis.$refs.listProcess.tablePagination(the same sourceonPageChangealready uses), guard against the modal's lazily-mounted ref, clamppage, then callfetch(). Mirrors the pattern already used inCasesRetentionLogs.vue, with extra null-safety because this component lives inside a<b-modal>and doesn't fetch oncreated.How To Test
- Ensure the list refreshes immediately, pagination shows "1 – 30 of N" (if 30+ processes exist).
<,>,<<,>>, and direct page numbers to ensure paging still works.ci:deploy
Code Review Checklist