Skip to content

Remove Microsoft Graph Configuration Caching #8910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanjacornelius merged 2 commits into from
Jul 16, 2026
+2 −11
Merged

Remove Microsoft Graph Configuration Caching #8910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc31cdb
Remove caching from Microsoft Graph token provider
sanjacornelius Jul 16, 2026
49018d4
Merge branch 'epic/FOUR-32115' into observation/FOUR-32273
sanjacornelius Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ProcessMaker/Mail/MicrosoftGraphTokenProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace ProcessMaker\Mail;

use GuzzleHttp\Client;
use Illuminate\Support\Facades\Cache;
use RuntimeException;

class MicrosoftGraphTokenProvider
Expand All @@ -15,17 +14,13 @@ class MicrosoftGraphTokenProvider
public function __construct(
private array $config,
private int|string $serverIndex = 0,
private ?Client $httpClient = null
private ?Client $httpClient = null,
) {
}

public function getAccessToken(): string
{
$cacheKey = 'microsoft_graph_access_token_' . ($this->serverIndex ?: 'default');

return Cache::remember($cacheKey, now()->addMinutes(50), function () {
return $this->requestAccessToken();
});
return $this->requestAccessToken();
}

private function requestAccessToken(): string
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/ProcessMaker/Mail/MicrosoftGraphTokenProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Response;
use Illuminate\Support\Facades\Cache;
use Mockery;
use ProcessMaker\Mail\MicrosoftGraphTokenProvider;
use RuntimeException;
Expand Down Expand Up @@ -34,8 +33,6 @@ public function testGetAccessTokenThrowsWhenCredentialsAreMissing()

public function testGetAccessTokenRequestsTokenFromMicrosoft()
{
Cache::flush();

$tokenResponse = new Response(200, [], json_encode(['access_token' => 'token-from-azure']));

$guzzle = Mockery::mock(Client::class);
Expand All @@ -60,6 +57,5 @@ public function testGetAccessTokenRequestsTokenFromMicrosoft()
], 1, $guzzle);

$this->assertSame('token-from-azure', $provider->getAccessToken());
$this->assertSame('token-from-azure', $provider->getAccessToken());
}
}
Loading