FOUR-32265: Normalize legacy data source IDs#1919
Open
eiresendez wants to merge 1 commit into
Open
Conversation
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
bugfix/FOUR-32265
|
| Run status |
|
| Run duration | 09m 46s |
| Commit |
|
| Committer | Eleazar Resendez |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
389
|
| View all changes introduced in this branch ↗︎ | |
|
|
QA server K8S was successfully deployed https://ci-4eca9cadc9.engk8s.processmaker.net |
mcraeteisha
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue & Reproduction Steps
A Collection-backed Select List can trigger a Data Connector watcher whose saved
script_iduses the legacy UI-prefixed format, such asdata_source-7.script_id: "data_source-7"./api/1.0/requests/data_sources/data_source-7and the resulting405 Method Not Allowedresponse.The regression fixture is included in
tests/e2e/fixtures/FOUR-6910_Watcher_Radio.json.Solution
data_source-{digits}before constructing Data Source URLs.DataProviderboundary for POST and cached GET requests.How to Test
npx jest tests/unit/DataProvider.spec.js --no-coverage --runInBandand confirm all 18 tests pass.npm run dev -- --host 127.0.0.1, then runenv -u ELECTRON_RUN_AS_NODE npm run run-cypress -- --spec tests/e2e/specs/SelectListWatcher.spec.js --browser chromeand confirm both tests pass.npm run buildand confirm the production bundle builds successfully./api/1.0/requests/data_sources/7, never/data_sources/data_source-7, and no 405 response occurs.Related Tickets & Packages
ci:deploy