Clear signature field when reopening the Record List Add modal#1920
Open
sanjacornelius wants to merge 1 commit into
Open
Clear signature field when reopening the Record List Add modal#1920sanjacornelius wants to merge 1 commit into
sanjacornelius wants to merge 1 commit into
Conversation
When the add-record modal is hidden, emit a "record-list-add-modal-hidden" event on window.ProcessMaker.EventBus so other components can react (e.g. refresh or cleanup). The handler still resets addItem to initFormValues and clears the addRenderer submitted state.
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
bugfix/FOUR-32231
|
| Run status |
|
| Run duration | 09m 50s |
| Commit |
|
| Committer | Sanja |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
389
|
| View all changes introduced in this branch ↗︎ | |
|
|
QA server K8S was successfully deployed https://ci-9594c19b23.engk8s.processmaker.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue & Reproduction Steps
This PR fixes an issue where the Signature component kept its previous value after closing the Record List Add modal with the Cancel button and reopening it.
The modal now emits a
record-list-add-modal-hiddenevent when it is hidden so components can react and reset their state as needed.Solution
record-list-add-modal-hiddenonwindow.ProcessMaker.EventBuswhen the Add modal is hidden.How to Test
Related Tickets & PRs
ci:deploy
Code Review Checklist