Skip to content

Add Xiaomi and POCO seed devices#370

Merged
Producdevity merged 4 commits into
stagingfrom
data/xiaomi-seed-devices
May 24, 2026
Merged

Add Xiaomi and POCO seed devices#370
Producdevity merged 4 commits into
stagingfrom
data/xiaomi-seed-devices

Conversation

@Producdevity
Copy link
Copy Markdown
Owner

@Producdevity Producdevity commented May 24, 2026

Description

Re-applies the Xiaomi/POCO seed data from #308 on the current staging branch.

Adds the requested Xiaomi and POCO devices from #258, #287, #298, and #305, along with the two missing Snapdragon SoCs they reference. I kept David Leblay as the commit author so the original PR author gets credit, and corrected the POCO M8 entry to match the issue as POCO M8 5G.

Fixes #258
Fixes #287
Fixes #298
Fixes #305

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor
  • Other (please describe):

How Has This Been Tested?

  • Local build
  • Lint
  • Typecheck
  • Unit tests
  • Manual testing

Screenshots (if applicable)

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I have checked that all checks (lint, typecheck, test) pass

Notes for reviewers

Keep @Leblayd / David Leblay as the commit author so the original PR author gets credit.

Summary by CodeRabbit

  • Chores
    • Added support for additional Xiaomi devices and Snapdragon processors to the system database.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
emuready Ready Ready Preview, Comment May 24, 2026 9:16am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 682692df-5655-4fa3-a6bf-bf40de5cf755

📥 Commits

Reviewing files that changed from the base of the PR and between 8946a14 and 3d1c403.

📒 Files selected for processing (2)
  • prisma/seeders/devicesSeeder.ts
  • prisma/seeders/socSeeder.ts

Walkthrough

This PR extends the device and SoC seed data by adding two new Snapdragon processors and four new Xiaomi devices. The SoC entries define processor specifications, while device entries reference them by name. No logic or exported functions are modified.

Changes

Seed Data for New Devices and SoCs

Layer / File(s) Summary
SoC seed entries
prisma/seeders/socSeeder.ts
Snapdragon 8 Elite Gen 5 and Snapdragon 6 Gen 3 are added to the socs array with processor architecture, manufacturing process, CPU cores, and GPU details.
Device seed entries
prisma/seeders/devicesSeeder.ts
Four Xiaomi devices are inserted: Black Shark 4 Pro (Snapdragon 888), 17 Pro (Snapdragon 8 Elite Gen 5), POCO F8 Pro (Snapdragon 8 Elite), and POCO M8 5G (Snapdragon 6 Gen 3).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary change: adding Xiaomi and POCO seed devices to the database.
Description check ✅ Passed The description is comprehensive, referencing linked issues, explaining the changes, and confirming passing tests despite not filling all template checkboxes.
Linked Issues check ✅ Passed All four device requests (#258, #287, #298, #305) are addressed with matching Xiaomi/POCO devices and required SoCs added to seed data.
Out of Scope Changes check ✅ Passed Changes are limited to adding requested seed data for devices and SoCs; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch data/xiaomi-seed-devices
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch data/xiaomi-seed-devices

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Producdevity Producdevity merged commit 05c261f into staging May 24, 2026
7 checks passed
@Producdevity Producdevity deleted the data/xiaomi-seed-devices branch May 24, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Request]: Xiaomi 17 Pro [Device Request]: Xiaomi Black Shark 4 Pro [Device Request]: Xiaomi Poco M8 5G [Device Request]: {Poco F8 Pro}

2 participants