Fix issue template links#417
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes GitHub issue links that were pointing at Markdown template filenames even though the repository now uses YAML issue forms. The support and emulator-request URLs now target the matching
.ymltemplates, and the emulator selector reuses the shared env URL instead of duplicating the GitHub link.Fixes #415
Type of change
How Has This Been Tested?
Checked with:
./node_modules/.bin/eslint src/lib/env.ts src/app/listings/components/shared/selectors/EmulatorSelector.tsxrg -n "issues/new\?template=.*\.md|template=question\.md|template=emulator_request\.md" src .githubgit diff --checkI also tried
./node_modules/.bin/tsc --noEmit --pretty false; it currently stops onsrc/components/icons/systems/SegaSaturnIcon.tsxbecause the PNG asset import has no matching module declaration in this local setup.Screenshots (if applicable)
Not applicable.
Checklist
Notes for reviewers
This is limited to GitHub issue creation links. The regular issue picker config is unchanged.
Summary by CodeRabbit