Open
Conversation
Collaborator
Author
|
cherry picked changes from Pull request #434 to avoid conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
What & Why
FactoryTest_wMenu.inointo aFactoryTest_wMenu/subdirectory (mirrors GPAD_API layout)platformio.initargeting ESP32 with all library dependencies explicitly defined:LiquidCrystal_I2C,DFRobotDFPlayerMini,esp32async/AsyncTCP,esp32async/ESPAsyncWebServer,ElegantOTA,OneButton.gitignoreto exclude PlatformIO build artifacts (.pio/)Note on AsyncTCP / ESPAsyncWebServer library owners:
The
lib_depsusesesp32async/AsyncTCPandesp32async/ESPAsyncWebServerrather than the oldermathieucarbou/variants.ElegantOTA 3.1.7declaresesp32async/ESPAsyncWebServer@^3.7.3as its own dependency inlibrary.json, which in turn pullsesp32async/AsyncTCP@^3.4.10.Listing the
mathieucarbou/packages alongside would cause PlatformIO to install duplicate libraries and produce build errors, since PlatformIO treats different owner names as distinct packages even when the code is identical.Validation / How to Verify
Firmware/factoryTest/FactoryTest_wMenu/in VS Code with the PlatformIO extension installedArtifacts (attach if relevant)
Checklist