fix(serialization): support new QNR anonymous notebook module#26
Merged
MichaelHatherly merged 1 commit intomainfrom Mar 17, 2026
Merged
fix(serialization): support new QNR anonymous notebook module#26MichaelHatherly merged 1 commit intomainfrom
MichaelHatherly merged 1 commit intomainfrom
Conversation
`deserialize_module` hardcoded `Main.Notebook` which crashes on new QNR where the notebook module is anonymous via `Module(:Notebook)`. Add `_notebook_module()` with dispatch-based override in the `Requires.@require` block (matching `_caching_options` pattern) to try `NotebookState.notebook_module()` first, fall back to `Main.Notebook`, then `Main`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deserialize_modulehardcodedMain.Notebookwhich crashes on newQNR where the notebook module is anonymous via
Module(:Notebook).Add
_notebook_module()with dispatch-based override in theRequires.@requireblock (matching_caching_optionspattern) totry
NotebookState.notebook_module()first, fall back toMain.Notebook, thenMain.