Fix MiniWebApp POST contact empty name after static guard (#10389 follow-up)#10428
Merged
Conversation
Bind superglobal scope slots from context before parent-frame inheritance so MiniWebApp contact POST keeps the posted name. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat examples-*-smoke ending with ": ok" as green despite opt-in slice skips, and refresh inventory line refs after Block.php superglobal fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Import PHPCompiler\JIT in the JIT namespace helper linker so compile-time VM helper lowering can instantiate the compiler during phpc build. Co-authored-by: Cursor <cursoragent@cursor.com>
Use BasicBlockHelper::tryGetInsertBlock after runtime helper linking so nested JIT bootstrap (ObGzhandler, #10360) no longer fatals on LLVMGetInsertBlock null. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Follow-up commits on this branch:
ThrowsWeb AOT (007) still fails later with 005-SessionsWeb POST flash (303 vs 200) reproduces on |
Owner
Author
|
Additional commits on this branch:
Verified: 007-ThrowsWeb AOT link still fails later at LLVM module verify (user-class IR issues — separate from the prior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_REQUEST['name']read in the caller stays populated after a static guard method (003-MiniWebAppRouter::contactNameIsValid()→dispatch()).examples-*-smoke: okas green inrelease-readiness.sh --fulleven when opt-in AOT slices skip (e.g.SESSIONS_WEB_AOT_SMOKE_GATE=0).docs/bootstrap-inventory.mdline refs afterBlock.phpchange.Follow-up to #10389 (merged header/
??fixes only); this lands the MiniWebApp contact POST regression fix that was developed on the same branch.Test plan
RequestSecondReadAfterStaticGuardTest(compliance PHPT)MiniWebAppVmCliTest::testPostQueryRouteContactThankYou./script/examples-web-smoke.sh(003 contact PATH_INFO POST)./script/release-readiness.sh --full --json→user_release_ready: yesMade with Cursor