Conversation
WyattBlue
force-pushed
the
patch
branch
5 times, most recently
from
7248205 to
682cc41
Compare
Muxing packets into Matroska failed in avformat_write_header because the muxer needs CodecPrivate (the codec extradata) before the first packet. For codec-less mux streams whose format embeds a global header, buffer packets and run the extract_extradata bitstream filter to recover the parameter sets from the bitstream, then set them on codecpar before the header is written. Streams give up after their first packet, so already length-prefixed packets fall back to the muxer's default behavior with no regression. closes #2198
actions/setup-python provides the python.org universal2 CPython, so setuptools compiled the extensions for arm64 and x86_64. Also stop installing libvorbis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Muxing pre-encoded H.264 packets into Matroska failed in avformat_write_header because the muxer needs CodecPrivate (the codec extradata) before the first packet, but add_mux_stream never set it.
For codec-less mux streams whose format embeds a global header, buffer packets and run the extract_extradata bitstream filter to recover the parameter sets from the bitstream, then set them on codecpar before the header is written. Streams give up after their first packet, so already length-prefixed packets fall back to the muxer's default behavior with no regression. The extraction uses direct libav calls (av_bsf_*, av_packet_get_side_data, memcpy) to avoid per-byte copies and wrapper allocations.
closes #2198