Conversation
test_streams.py::test_loudnorm calls av.filter.loudnorm, so add loudnorm to the trimmed smoke-build filter list; without it the filter lookup returned NULL. That NULL also exposed a crash: loudnorm_get_stats() built an abuffer -> loudnorm -> abuffersink graph but ignored every return code, so a NULL loudnorm context was passed to avfilter_link() and segfaulted the interpreter. Bail out early if a required filter is missing, check the create_filter/link/graph_config return codes so a NULL context can never be linked, free the graph on the error path, and skip the 5s JSON wait when no graph ran. On failure the function returns NULL, which the Python wrapper already turns into a RuntimeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.