Skip to content

style(tui): grey out dark-theme borders and input rules - #152

Merged
elkaix merged 2 commits into
mainfrom
style/tui-grey-borders
Jun 15, 2026
Merged

style(tui): grey out dark-theme borders and input rules#152
elkaix merged 2 commits into
mainfrom
style/tui-grey-borders

Conversation

@elkaix

@elkaix elkaix commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

Darkens the dark-theme chrome so panel borders and input-area rules no longer glare near-white.

  • border token (and compact-input.frame) move from #e8ebed (near-white) to #8a8d91 (mid grey) in the dark theme — affects the welcome banner, menus, and the compact input rules.
  • Tests updated to assert the new token value.

Verification

uv run pytest tests/ui_and_conv/test_shell_panel.py tests/ui_and_conv/test_tui_theme_tokens.py -q
# 25 passed

Changelog entry added under ## Unreleased.

Summary by CodeRabbit

  • Style
    • Dark theme: Panel borders (welcome banner, menus) and input area styling now use a softer mid-grey color for improved visual comfort.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c1f46b3c-e6bb-4cae-b3c5-6c4eb4865865

📥 Commits

Reviewing files that changed from the base of the PR and between 8c3f521 and fcbfccb.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • src/pythinker_code/ui/theme.py
  • tests/ui_and_conv/test_shell_panel.py
  • tests/ui_and_conv/test_tui_theme_tokens.py

📝 Walkthrough

Walkthrough

Two hex color values in the dark TUI theme are changed from #e8ebed to #8a8d91: the compact-input.frame foreground in _PROMPT_STYLE_DARK and the border semantic token in _TUI_TOKENS_DARK. Two test assertions and a changelog entry are updated to match.

Changes

Dark theme border color update

Layer / File(s) Summary
Dark theme color values and test assertions
src/pythinker_code/ui/theme.py, tests/ui_and_conv/test_shell_panel.py, tests/ui_and_conv/test_tui_theme_tokens.py, CHANGELOG.md
compact-input.frame and border token changed from #e8ebed to #8a8d91; both border-color test assertions updated to the new value; changelog entry added under Unreleased.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

enhancement

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 70.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title follows conventional commits format with valid type 'style' and scope 'tui', clearly describing the change to dark-theme borders and input rules.
Description check ✅ Passed Description includes summary, specific changes, verification with test results, and changelog confirmation. Related issue section is not filled, but overall structure is complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch style/tui-grey-borders

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@elkaix
elkaix merged commit 1ad0339 into main Jun 15, 2026
30 checks passed
@elkaix
elkaix deleted the style/tui-grey-borders branch June 15, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant