fix(tui): model-aware thinking levels, vscode truecolor, suppress reload banner - #175
Conversation
…oad banner Scope GPT-5 reasoning effort to each model's supported set, promote VS Code-family terminals to truecolor for diff tints, and skip the welcome splash on same-session reloads.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFour independent fixes ship together: GPT-5-family thinking-effort levels are clamped per model version before reaching the API using new ChangesGPT-5 reasoning clamping, VS Code truecolor, and banner suppression
Diff background color stripping
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Code-theme backgrounds masked diff row tints and caused a blue overlay in VS Code-family terminals; drop bg on highlighted spans so add/remove tints and the terminal background show through.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/utils/test_diff_render.py`:
- Around line 667-670: The test mutates the global code theme by calling
set_active_code_theme("catppuccin-adaptive") without restoring it, which can
cause test-order coupling. Add a new autouse fixture named
_restore_active_code_theme that saves the current active code theme before the
test runs using get_active_code_theme(), yields to allow the test to execute,
and then restores the original theme in a finally block using
set_active_code_theme(). This fixture should import get_active_code_theme and
set_active_code_theme from pythinker_code.utils.rich.syntax, following the same
pattern already demonstrated in tests/ui_and_conv/test_code_theme_opt_in.py.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a6237d54-962e-49e8-9e13-caf3d34374ab
📒 Files selected for processing (3)
CHANGELOG.mdsrc/pythinker_code/utils/rich/diff_render.pytests/utils/test_diff_render.py
Add autouse fixture so set_active_code_theme in background-stripping test does not leak process-global state between tests.
Refresh required checks after test fixture commit.
Summary
minimalon gpt-5.4/5.5).TERM_PROGRAM=vscode) to truecolor so diff add/remove tints render correctly instead of falling back to the 16-color path./model,/theme,/new, fork, …) while keeping it for/clearand/reload.Test plan
tests/core/test_model_thinking_levels.py— GPT-5 reasoning matrix and clampingtests/ui_and_conv/test_terminal_capabilities.py— VS Code truecolor promotiontests/ui_and_conv/test_shell_run_placeholders.py— banner suppress on reloadmake check-pythinker-code && make test-pythinker-code(CI)Summary by CodeRabbit