fix(ci): extend promote-release asset-wait budget to 40m - #25
Merged
Conversation
The promote-release job runs on the tag push, in parallel with the platform build workflows, and polls for all release assets before clearing the prerelease flag and marking the release latest. The budget was 40x30s = 20 minutes. On the 0.26.0 release the linux-installer workflow (emulated arm64 .deb/.rpm) did not finish attaching its assets until ~21 minutes after the tag push — 45 seconds after the poll budget had already expired. The promote job failed, leaving v0.26.0 stuck as a prerelease so /releases/latest kept resolving to the previous version until a manual re-promote. Extend the budget to 80x30s = 40 minutes (~2x margin over the observed long-pole build) and surface the attempt count / budget from named variables. A genuinely stuck build still surfaces as its own failed build workflow, and the workflow_dispatch re-promote path is unchanged.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe "Wait for all release assets" step in the promote-release workflow now uses configurable polling parameters (80 attempts, 30-second intervals) with a computed time budget, replacing a fixed 40-attempt loop and hardcoded 20-minute timeout messaging. Attempt logging and failure messages report the calculated budget. ChangesConfigurable release asset polling timeout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
promote-releaseworkflow runs on the tag push, in parallel with the platform build workflows, and polls for all release assets before clearing the prerelease flag and marking the release latest. The asset-wait budget was40 × 30s = 20 minutes.On the 0.26.0 release (the first real exercise of this flow, shipped in #24) the
linux-installerworkflow — whose long pole is the emulated arm64.deb/.rpmbuild — did not finish attaching its assets until ~21 minutes after the tag push, 45 seconds after the poll budget had already expired:The
promotejob failed, leaving v0.26.0 stuck as a prerelease, so/releases/latestkept resolving to v0.25.0 until a manualworkflow_dispatchre-promote. (0.26.0 has since been promoted manually; this prevents recurrence.)This was not a pattern-matching bug — all 9 required asset substrings were present once builds finished; the budget was simply shorter than the slowest build.
Fix
Extend the budget to
80 × 30s = 40 minutes(~2× margin over the observed long-pole build) and surface the attempt count / budget from named variables (max_attempts,poll_interval) instead of hardcoded literals.A genuinely stuck or failed build still surfaces as its own failed build workflow, and the
workflow_dispatchre-promote path is unchanged.Summary by CodeRabbit