fix(ci): restore version-tag trigger glob in release workflows - #46
Merged
Conversation
fb7fdbf changed the v* tag trigger from "v[0-9]+.[0-9]+.[0-9]+" to "v+([0-9]).+([0-9]).+([0-9])". GitHub Actions ref filters are not ksh extglob — `(` and `)` are literal, so the new pattern matches no real version tag and silently fires nothing. v0.28.0 was the first tag pushed after the change and triggered zero release/installer/promote/distribution workflows. Restore the proven "v[0-9]+.[0-9]+.[0-9]+" pattern (which shipped v0.24.0–v0.27.0) across all 7 affected workflows: release-pythinker-cli, promote-release, linux-installer, windows-installer, homebrew-tap, scoop-bucket, docker. The pythinker-core/host/sdk release workflows use pythinker-*-* globs and were unaffected. [skip changelog] — CI trigger fix, no user-facing product change.
Contributor
📝 WalkthroughWalkthroughSeven GitHub Actions workflows are updated to standardize semantic version tag-matching. Each workflow's ChangesSemantic Version Tag Matching
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release-pythinker-cli.yml:
- Around line 3-6: Add a top-level concurrency block to the tag-triggered
workflow to prevent overlapping release runs: in the
.github/workflows/release-pythinker-cli.yml workflow (the one with on: push:
tags: - "v[0-9]+.[0-9]+.[0-9]+"), add a concurrency key with a stable group name
(e.g., using github.ref or a release identifier) and set cancel-in-progress:
true so that concurrent tag pushes won’t run overlapping release jobs and avoid
race conditions during publishing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4cd8a60e-a372-4e13-a97e-c2809d63cf77
📒 Files selected for processing (7)
.github/workflows/docker.yml.github/workflows/homebrew-tap.yml.github/workflows/linux-installer.yml.github/workflows/promote-release.yml.github/workflows/release-pythinker-cli.yml.github/workflows/scoop-bucket.yml.github/workflows/windows-installer.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
fb7fdbf ci(actions): update workflows for Node 24rewrote thev*tag trigger:GitHub Actions ref filters are not ksh extglob —
(and)are literal characters, sov+([0-9]).+([0-9]).+([0-9])only matches a tag containing literal parentheses. No real version tag matches, so the trigger silently fires nothing.v0.28.0was the first tag pushed after this change and triggered zero workflows (verified: pushed both lightweight and annotated tags, neither produced a run; GitHub status all-operational).Blast radius
The broken pattern was applied to all 7
v*-tag-triggered workflows:release-pythinker-cli(PyPI + GitHub release),promote-release,linux-installer,windows-installer,homebrew-tap,scoop-bucket,docker. The whole release pipeline was dead for tagged releases. (release-pythinker-{core,host,sdk}usepythinker-*-*globs and were unaffected.)Fix
Restore the proven
"v[0-9]+.[0-9]+.[0-9]+"pattern — the exact one that shipped v0.24.0–v0.27.0 — across all 7 files. Five of them regressed from this pattern infb7fdbf;scoop-bucketanddockerare newer (added after v0.27.0) and were born with the broken pattern.After this merges,
v0.28.0is re-tagged onto the fixed commit (GitHub evaluates the tag trigger from the workflow file at the tagged commit, so the tag must point past this fix).[skip changelog] — CI trigger fix, no user-facing product change.
Summary by CodeRabbit