fix(windows): wipe _internal before upgrade to prevent stale dist-info version - #67
Merged
Merged
Conversation
…o version
Inno Setup's ignoreversion recursesubdirs adds files but never removes
obsolete ones, so in-place upgrades left both pythinker_code-0.28.0.dist-info
and pythinker_code-0.31.0.dist-info under _internal. importlib.metadata picks
the first path-finder match, which is the alphabetically-lower (older) version,
causing the UI to show the old version number and re-trigger the update prompt
after every successful upgrade. Uninstall+reinstall worked cleanly because
the uninstaller wiped {app} entirely.
Add [InstallDelete] to remove {app}\_internal before [Files] runs so each
upgrade starts from a clean directory. _internal is 100% PyInstaller app
payload; no user data lives there. Add a regression assertion to prevent
this section from being silently dropped.
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignoreversion recursesubdirsadds/overwrites files but never removes obsolete directories, so in-place upgrades left bothpythinker_code-0.28.0.dist-infoandpythinker_code-0.31.0.dist-infounder_internalimportlib.metadata.version()returns the first path-finder match; alphabetical order puts0.28.0before0.31.0, so the running 0.31.0 binary reported its version as0.28.0{app}entirelyFix: Add
[InstallDelete]toinstaller.issto delete{app}\_internalbefore[Files]runs._internalis 100% PyInstaller app payload — no user data lives there. Also adds a regression assertion totest_release_update_pipeline.pyso this section can't be silently dropped.Test plan
test_release_update_pipeline.pysuite passes (7/7) — includes new assertion that[InstallDelete]targets{app}\_internalmake check-pythinker-codepasses (ruff + pyright clean)