-
Notifications
You must be signed in to change notification settings - Fork 6
fix(web): align the MCP server form and the provider dialog corners #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@pymodel/pythinker-code": patch | ||
| --- | ||
|
|
||
| Lay the MCP server form out in even rows instead of a ragged grid, and stop the provider manager header and footer from squaring off the dialog corners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { readFileSync } from 'node:fs'; | ||
| import { resolve } from 'node:path'; | ||
|
|
||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| // The header, the footer, and the provider list all paint their own background | ||
| // to the dialog edge, so a rounded dialog needs to clip them. jsdom applies no | ||
| // scoped-SFC styles, so the rule itself is the contract under test. | ||
| const source = readFileSync( | ||
| resolve(import.meta.dirname, '../src/components/ProviderManager.vue'), | ||
| 'utf8', | ||
| ); | ||
|
|
||
| function blockOf(selector: string): string { | ||
| const start = source.indexOf(`\n${selector} {`); | ||
| expect(start).toBeGreaterThan(-1); | ||
| const end = source.indexOf('\n}', start); | ||
| return source.slice(start, end); | ||
| } | ||
|
|
||
| describe('ProviderManager dialog chrome', () => { | ||
| it('clips its children to the rounded corners', () => { | ||
| const dialog = blockOf('.dialog'); | ||
|
|
||
| expect(dialog).toMatch(/border-radius:\s*4px/u); | ||
| expect(dialog).toMatch(/overflow:\s*hidden/u); | ||
| }); | ||
|
|
||
| it('leaves the corner rounding to the dialog instead of the footer', () => { | ||
| expect(blockOf('.footer-hint')).not.toMatch(/border-radius/u); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.