fix(ci): harden release and CodeQL checks - #164
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe PR updates OAuth identity hashing to use UTF-8 bytes, improves Nix base-reference selection, revises stale-hash diagnostics, and adds integration tests for release and lockfile-only branches. ChangesNix hash freshness
OAuth identity hashing
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR hardens release validation and preserves OAuth digest compatibility; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
commit: |
Related Issue
No issue. This maintainer follow-up fixes failed
mainRelease run 32620664188 and the linked CodeQL configuration warning.Problem
The Nix lock freshness check preferred a release branch's stale upstream over the current default branch. Changesets release PRs could therefore fail after they reset onto a newer
main. The CodeQL analysis also emitted an oversized related-location warning because public OAuth endpoint identifiers flowed directly into a SHA-256 filename fingerprint and were classified as password-like values.What changed
origin/HEAD, thenorigin/main, before a branch upstream.Verification
pnpm lintpnpm run typecheckpnpm run testpnpm run buildnix build .#pythinker-codepnpm run sherifnode scripts/check-nix-workspace.mjsChecklist
gen-changesets; no changeset because behavior and published output are unchanged.Summary by CodeRabbit
Bug Fixes
Tests