fix: keep the live thinking effort when switching models - #69
Closed
elkaix wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
commit: |
5 tasks
elkaix
added a commit
that referenced
this pull request
Aug 14, 2026
## Related Issue No issue — follow-up to #66 (GitHub org migration). This PR moves the npm side to the new org. ## Problem The GitHub org moved to `PyModel` (#66), but every workspace package still carries the `@pythoughts` npm scope, and releases still publish to `@pythoughts/pythinker-code`. Newer versions must publish under the `pymodel` npm org. ## What changed - Renamed all 18 workspace packages from `@pythoughts/*` to `@pymodel/*`: package names, workspace dependencies, imports, and every tooling reference (changesets config, `flake.nix` workspace names, CI workflows, release/native/brew/CDN scripts, docs, README badges). - Fixed escaped-scope references a plain replace misses: the api-extractor specifier-rewrite regex in the SDK dts build, vitest/tsdown `alwaysBundle` regexes, and the Windows path marker in the postinstall reach script. - Regenerated `pnpm-lock.yaml`; the `flake.nix` `pnpmDeps` hash is unchanged (verified by rebuilding — workspace names do not affect the fetched dependency set). - Added a `minor` changeset so the next release publishes `@pymodel/pythinker-code`. Out of scope: the VS Code Marketplace publisher (`pythoughts.pythinker-code`), `api.pythoughts.com` platform URLs, and the `ai.pythoughts.pythinker-server` LaunchAgent label — these are separate identities, not npm scope. ## Merge order Merge #67, #68, #69 first — their changesets name `@pythoughts/pythinker-code` and would break `changeset version` if this PR lands before them. ## Before the first publish (npm side, manual) 1. On npmjs.com, add a Trusted Publishing (OIDC) connection for `@pymodel/pythinker-code`: repository `PyModel/pythinker-code`, workflow `release.yml`. 2. After the first successful `@pymodel` release: `npm deprecate @pythoughts/pythinker-code "Moved to @pymodel/pythinker-code"`. ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md) document. - [x] I have linked a related issue, or explained the problem above. - [x] I have added tests that prove my feature works. (Mechanical rename; existing suites cover it.) - [x] Ran `gen-changesets` skill, or this PR needs no changeset. - [x] Ran `gen-docs` skill, or this PR needs no doc update. (Docs updated in the sweep.) ## Additional commits - The sweep also caught encoded-scope references a plain replace misses: api-extractor/tsdown/vitest regexes (`@pythoughts\/`), release-tag parsing in `produce-manifest.mjs` and `install.sh`, `%40…%2F` release-download URLs in the CDN build, and split specifiers in tests. - One drive-along test-infra fix: `skill-session.test.ts` temp-dir cleanup now retries, because a late journal flush races the recursive delete under full-suite load and threw ENOTEMPTY twice while gating this push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue — the problem is explained below.
Problem
Two more paths lose the user's saved thinking effort across restarts (follow-up to #67):
lowfor models without effort metadata). Confirming the picker persists that draft as the startup default, silently overwriting the effort the user had saved. A real config was found holdingeffort = "low"this way.thinking.effort; the config deep merge preserves a stalethinking.mode = "off", which forces thinking off on the next startup even when an effort is saved.What changed
thinking.mode(on/off), so a stalemode = "off"cannot poison restarts.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.