chore: remove apps/site, now owned by the private site repository

.github/workflows/release.yml

@@ -203,13 +203,17 @@ jobs:
           retention-days: 7
           if-no-files-found: error
 
-  # code.pythinker.com redeploys via Dokploy autodeploy on push to main (app
-  # Pythinker/code builds apps/site/Dockerfile from the repo). That autodeploy
-  # fires on the `ci: release packages` push — which STARTS the release — while
-  # apps/site/scripts/build-cdn.mjs reads the version from npm's dist-tag, which
-  # only moves when the publish FINISHES. The first build therefore bakes in the
-  # previous version and nothing rebuilds it, so the release stays invisible to
-  # every installed client. This job fires a second deploy after the publish.
+  # code.pythinker.com is built from the private repository PyModel/pythinker-site,
+  # which owns the site source and its build-cdn.mjs. Dokploy autodeploys on push
+  # to THAT repository, so nothing in this repository triggers a CDN rebuild — this
+  # job is the only thing that does after a release.
+  #
+  # It has to exist because the CDN resolves the version it advertises from npm's
+  # dist-tag, which only moves when the publish FINISHES. Without this job a
+  # release would publish to npm and the CDN would keep serving the previous
+  # version until someone happened to push to the site repository, leaving the
+  # release invisible to every installed client. This job fires the deploy that
+  # picks the new dist-tag up.
   #
   # It must run after publish-native-assets: latest.json only gets its
   # per-platform `platforms` block once the native zips exist on the release.

apps/desktop/tests/packaging-config.spec.ts

@@ -73,23 +73,11 @@ describe('desktop packaging configuration', () => {
     })
   })
 
-  it('keeps desktop download URLs derived from their published release version', () => {
-    const siteSource = readFileSync(resolve(repositoryRoot, 'apps/site/src/App.vue'), 'utf8')
-    const desktopVersionMatch = siteSource.match(/const DESKTOP_VERSION = '([^']+)'/)
-
-    expect(desktopVersionMatch).not.toBeNull()
-    expect(desktopVersionMatch![1]).not.toBe('')
-    expect(siteSource).not.toContain('Pythinker-0.1.0-arm64.dmg')
-    expect(siteSource).not.toContain('Pythinker-0.1.0-x64-Setup.exe')
-    expect(siteSource).toContain('Pythinker-${DESKTOP_VERSION}-arm64.dmg')
-    expect(siteSource).toContain('Pythinker-${DESKTOP_VERSION}-x64-Setup.exe')
-    expect(siteSource).toContain('releases/download/v${DESKTOP_VERSION}')
-    expect(siteSource).not.toContain('releases/download/v0.1.0')
-
-    const desktopShowcaseMatch = siteSource.match(/<section id="desktop"[\s\S]*?<\/section>/)
-    expect(desktopShowcaseMatch).not.toBeNull()
-    expect(desktopShowcaseMatch![0]).toContain('/brand/windows11.svg')
-  })
+  // A test here used to read the site's App.vue and assert that the download
+  // buttons on code.pythinker.com interpolated the desktop release version
+  // instead of hardcoding one. The site moved to the private repository
+  // PyModel/pythinker-site, so nothing in this repository can see those links
+  // any more and the check has to live there. It is not covered here.
 
   it('maps the staged Host node_modules directory as the copy root', () => {
     expect(desktopPackage.build.extraResources).toEqual(expect.arrayContaining([