ci: include coverage from running build scripts#6007
Conversation
|
Thanks for working on this! I noticed this looking at our clverage output for my build configuration PR. Happy to help out if you want a hand or an eye for review. |
|
This depends on taiki-e/cargo-llvm-cov#493 merging & releasing first. |
|
Just needs https://github.com/taiki-e/install-action to have a new release to pick this up (currently 2.77.7). |
|
Looks like this worked. Might be useful to merge before #5807 |
ngoldbaum
left a comment
There was a problem hiding this comment.
I did a little AI-assisted code review and spotted a few issues. See below.
Overall looks good and I'm happy with this going in although I'm not sure about the manylinux question below.
| - os: "ubuntu-latest" | ||
| target: "x86_64-unknown-linux-gnu" | ||
| flags: "-i python3.13" | ||
| manylinux: auto |
There was a problem hiding this comment.
Is there any way to install the needed packages on the manylinux containers? Otherwise we lose that we're checking compatibility with the manylinux ABI.
Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com> Co-authored-by: David Hewitt <mail@davidhewitt.dev>
|
I think I've managed to revert the |
This attempts to improve coverage measurement of
pyo3-build-configby measuring the coverage of invocation ofbuild.rsfiles.I refactored a few common pieces about coverage measurement into helper actions so that I could re-use them from
test-version-limitsjob.