Skip to content

Add clippy lints to prepare for no_std support#6029

Merged
davidhewitt merged 4 commits into
PyO3:mainfrom
Person-93:clippy_lints_no_std
May 16, 2026
Merged

Add clippy lints to prepare for no_std support#6029
davidhewitt merged 4 commits into
PyO3:mainfrom
Person-93:clippy_lints_no_std

Conversation

@Person-93
Copy link
Copy Markdown
Contributor

In this PR I

  • added clippy lints to the main crate
  • added extern crate alloc to lib.rs
  • updated import paths to satisfy the lint

There are no functional changes in this PR.

@Person-93 Person-93 force-pushed the clippy_lints_no_std branch 2 times, most recently from 344d34c to 5886cf1 Compare May 11, 2026 00:28
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally LGTM.

Just realised there is a second layer to this - a lot the macros emit a lot of code which uses std. I suspect we can't lint against that in the same way (will probably need to leverage the hygiene test running in a no_std configuration). I guess that can be a follow-up?

Comment thread src/types/string.rs
@Person-93 Person-93 force-pushed the clippy_lints_no_std branch from 5886cf1 to e54cf76 Compare May 11, 2026 14:46
@davidhewitt davidhewitt added CI-skip-changelog Skip checking changelog entry CI-build-full labels May 12, 2026
@Person-93
Copy link
Copy Markdown
Contributor Author

@davidhewitt is this waiting on anything else?

@davidhewitt
Copy link
Copy Markdown
Member

Let's send it and see what happens!

@davidhewitt davidhewitt added this pull request to the merge queue May 16, 2026
Merged via the queue into PyO3:main with commit 1db8092 May 16, 2026
89 of 90 checks passed
@Person-93 Person-93 deleted the clippy_lints_no_std branch May 18, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-build-full CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants